content/browser/renderer_host/render_widget_host_impl.cc - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_impl.h ('k') | content/browser/renderer_host/render_widget_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_impl.cc

diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc

index f152c57916ac229b736484ec5016bb1406c4f327..47cfba2ddb69631109eb6705c7461099e4835400 100644

--- a/content/browser/renderer_host/render_widget_host_impl.cc

+++ b/content/browser/renderer_host/render_widget_host_impl.cc

@@ -124,8 +124,7 @@ class RenderWidgetHostIteratorImpl : public RenderWidgetHostIterator {

: current_index_(0) {

}

- virtual ~RenderWidgetHostIteratorImpl() {

- }

+ ~RenderWidgetHostIteratorImpl() override {}

void Add(RenderWidgetHost* host) {

hosts_.push_back(RenderWidgetHostID(host->GetProcess()->GetID(),

@@ -133,7 +132,7 @@ class RenderWidgetHostIteratorImpl : public RenderWidgetHostIterator {

}

// RenderWidgetHostIterator:

- virtual RenderWidgetHost* GetNextHost() override {

+ RenderWidgetHost* GetNextHost() override {

RenderWidgetHost* host = NULL;

while (current_index_ < hosts_.size() && !host) {

RenderWidgetHostID id = hosts_[current_index_];