Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Unified Diff: content/browser/plugin_data_remover_impl.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/plugin_data_remover_impl.h ('k') | content/browser/plugin_data_remover_impl_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/plugin_data_remover_impl.cc
diff --git a/content/browser/plugin_data_remover_impl.cc b/content/browser/plugin_data_remover_impl.cc
index 1f6f615d6c73f74624013a8eac49eca608b25746..f74b37831b5b3d867513aaa15fba31ffcfb60130 100644
--- a/content/browser/plugin_data_remover_impl.cc
+++ b/content/browser/plugin_data_remover_impl.cc
@@ -122,32 +122,28 @@ class PluginDataRemoverImpl::Context
}
// PluginProcessHost::Client methods.
- virtual int ID() override {
+ int ID() override {
// Generate a unique identifier for this PluginProcessHostClient.
return ChildProcessHostImpl::GenerateChildProcessUniqueId();
}
- virtual bool OffTheRecord() override {
- return false;
- }
+ bool OffTheRecord() override { return false; }
- virtual ResourceContext* GetResourceContext() override {
- return resource_context_;
- }
+ ResourceContext* GetResourceContext() override { return resource_context_; }
- virtual void SetPluginInfo(const WebPluginInfo& info) override {}
+ void SetPluginInfo(const WebPluginInfo& info) override {}
- virtual void OnFoundPluginProcessHost(PluginProcessHost* host) override {}
+ void OnFoundPluginProcessHost(PluginProcessHost* host) override {}
- virtual void OnSentPluginChannelRequest() override {}
+ void OnSentPluginChannelRequest() override {}
- virtual void OnChannelOpened(const IPC::ChannelHandle& handle) override {
+ void OnChannelOpened(const IPC::ChannelHandle& handle) override {
ConnectToChannel(handle, false);
// Balancing the AddRef call.
Release();
}
- virtual void OnError() override {
+ void OnError() override {
LOG(ERROR) << "Couldn't open plugin channel";
SignalDone();
// Balancing the AddRef call.
@@ -155,16 +151,15 @@ class PluginDataRemoverImpl::Context
}
// PpapiPluginProcessHost::BrokerClient implementation.
- virtual void GetPpapiChannelInfo(base::ProcessHandle* renderer_handle,
- int* renderer_id) override {
+ void GetPpapiChannelInfo(base::ProcessHandle* renderer_handle,
+ int* renderer_id) override {
*renderer_handle = base::kNullProcessHandle;
*renderer_id = 0;
}
- virtual void OnPpapiChannelOpened(
- const IPC::ChannelHandle& channel_handle,
- base::ProcessId /* peer_pid */,
- int /* child_id */) override {
+ void OnPpapiChannelOpened(const IPC::ChannelHandle& channel_handle,
+ base::ProcessId /* peer_pid */,
+ int /* child_id */) override {
if (!channel_handle.name.empty())
ConnectToChannel(channel_handle, true);
@@ -173,7 +168,7 @@ class PluginDataRemoverImpl::Context
}
// IPC::Listener methods.
- virtual bool OnMessageReceived(const IPC::Message& message) override {
+ bool OnMessageReceived(const IPC::Message& message) override {
IPC_BEGIN_MESSAGE_MAP(Context, message)
IPC_MESSAGE_HANDLER(PluginProcessHostMsg_ClearSiteDataResult,
OnClearSiteDataResult)
@@ -185,7 +180,7 @@ class PluginDataRemoverImpl::Context
return true;
}
- virtual void OnChannelError() override {
+ void OnChannelError() override {
if (is_removing_) {
NOTREACHED() << "Channel error";
SignalDone();
@@ -197,7 +192,7 @@ class PluginDataRemoverImpl::Context
private:
friend struct BrowserThread::DeleteOnThread<BrowserThread::IO>;
friend class base::DeleteHelper<Context>;
- virtual ~Context() {}
+ ~Context() override {}
IPC::Message* CreatePpapiClearSiteDataMsg(uint64 max_age) {
base::FilePath profile_path =
« no previous file with comments | « content/browser/plugin_data_remover_impl.h ('k') | content/browser/plugin_data_remover_impl_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698