Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: content/browser/download/download_manager_impl.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/download/download_manager_impl.h" 5 #include "content/browser/download/download_manager_impl.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 } 154 }
155 155
156 private: 156 private:
157 base::hash_map<int64, DownloadItem*>::const_iterator iter_; 157 base::hash_map<int64, DownloadItem*>::const_iterator iter_;
158 // Allow copy and assign. 158 // Allow copy and assign.
159 }; 159 };
160 160
161 class DownloadItemFactoryImpl : public DownloadItemFactory { 161 class DownloadItemFactoryImpl : public DownloadItemFactory {
162 public: 162 public:
163 DownloadItemFactoryImpl() {} 163 DownloadItemFactoryImpl() {}
164 virtual ~DownloadItemFactoryImpl() {} 164 ~DownloadItemFactoryImpl() override {}
165 165
166 virtual DownloadItemImpl* CreatePersistedItem( 166 DownloadItemImpl* CreatePersistedItem(
167 DownloadItemImplDelegate* delegate, 167 DownloadItemImplDelegate* delegate,
168 uint32 download_id, 168 uint32 download_id,
169 const base::FilePath& current_path, 169 const base::FilePath& current_path,
170 const base::FilePath& target_path, 170 const base::FilePath& target_path,
171 const std::vector<GURL>& url_chain, 171 const std::vector<GURL>& url_chain,
172 const GURL& referrer_url, 172 const GURL& referrer_url,
173 const std::string& mime_type, 173 const std::string& mime_type,
174 const std::string& original_mime_type, 174 const std::string& original_mime_type,
175 const base::Time& start_time, 175 const base::Time& start_time,
176 const base::Time& end_time, 176 const base::Time& end_time,
(...skipping 21 matching lines...) Expand all
198 last_modified, 198 last_modified,
199 received_bytes, 199 received_bytes,
200 total_bytes, 200 total_bytes,
201 state, 201 state,
202 danger_type, 202 danger_type,
203 interrupt_reason, 203 interrupt_reason,
204 opened, 204 opened,
205 bound_net_log); 205 bound_net_log);
206 } 206 }
207 207
208 virtual DownloadItemImpl* CreateActiveItem( 208 DownloadItemImpl* CreateActiveItem(
209 DownloadItemImplDelegate* delegate, 209 DownloadItemImplDelegate* delegate,
210 uint32 download_id, 210 uint32 download_id,
211 const DownloadCreateInfo& info, 211 const DownloadCreateInfo& info,
212 const net::BoundNetLog& bound_net_log) override { 212 const net::BoundNetLog& bound_net_log) override {
213 return new DownloadItemImpl(delegate, download_id, info, bound_net_log); 213 return new DownloadItemImpl(delegate, download_id, info, bound_net_log);
214 } 214 }
215 215
216 virtual DownloadItemImpl* CreateSavePageItem( 216 DownloadItemImpl* CreateSavePageItem(
217 DownloadItemImplDelegate* delegate, 217 DownloadItemImplDelegate* delegate,
218 uint32 download_id, 218 uint32 download_id,
219 const base::FilePath& path, 219 const base::FilePath& path,
220 const GURL& url, 220 const GURL& url,
221 const std::string& mime_type, 221 const std::string& mime_type,
222 scoped_ptr<DownloadRequestHandleInterface> request_handle, 222 scoped_ptr<DownloadRequestHandleInterface> request_handle,
223 const net::BoundNetLog& bound_net_log) override { 223 const net::BoundNetLog& bound_net_log) override {
224 return new DownloadItemImpl(delegate, download_id, path, url, 224 return new DownloadItemImpl(delegate, download_id, path, url,
225 mime_type, request_handle.Pass(), 225 mime_type, request_handle.Pass(),
226 bound_net_log); 226 bound_net_log);
(...skipping 490 matching lines...) Expand 10 before | Expand all | Expand 10 after
717 if (delegate_) 717 if (delegate_)
718 delegate_->OpenDownload(download); 718 delegate_->OpenDownload(download);
719 } 719 }
720 720
721 void DownloadManagerImpl::ShowDownloadInShell(DownloadItemImpl* download) { 721 void DownloadManagerImpl::ShowDownloadInShell(DownloadItemImpl* download) {
722 if (delegate_) 722 if (delegate_)
723 delegate_->ShowDownloadInShell(download); 723 delegate_->ShowDownloadInShell(download);
724 } 724 }
725 725
726 } // namespace content 726 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/download/download_manager_impl.h ('k') | content/browser/download/download_manager_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698