Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Side by Side Diff: content/browser/dom_storage/dom_storage_area_unittest.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/files/file_util.h" 6 #include "base/files/file_util.h"
7 #include "base/files/scoped_temp_dir.h" 7 #include "base/files/scoped_temp_dir.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "base/message_loop/message_loop_proxy.h" 9 #include "base/message_loop/message_loop_proxy.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 EXPECT_TRUE(area->SetItem(kKey2, kValue2, &old_value)); 51 EXPECT_TRUE(area->SetItem(kKey2, kValue2, &old_value));
52 EXPECT_TRUE(area->commit_batch_.get()); 52 EXPECT_TRUE(area->commit_batch_.get());
53 EXPECT_EQ(1, area->commit_batches_in_flight_); 53 EXPECT_EQ(1, area->commit_batches_in_flight_);
54 EXPECT_TRUE(area->HasUncommittedChanges()); 54 EXPECT_TRUE(area->HasUncommittedChanges());
55 } 55 }
56 56
57 // Class used in the CommitChangesAtShutdown test case. 57 // Class used in the CommitChangesAtShutdown test case.
58 class VerifyChangesCommittedDatabase : public DOMStorageDatabase { 58 class VerifyChangesCommittedDatabase : public DOMStorageDatabase {
59 public: 59 public:
60 VerifyChangesCommittedDatabase() {} 60 VerifyChangesCommittedDatabase() {}
61 virtual ~VerifyChangesCommittedDatabase() { 61 ~VerifyChangesCommittedDatabase() override {
62 const base::string16 kKey(ASCIIToUTF16("key")); 62 const base::string16 kKey(ASCIIToUTF16("key"));
63 const base::string16 kValue(ASCIIToUTF16("value")); 63 const base::string16 kValue(ASCIIToUTF16("value"));
64 DOMStorageValuesMap values; 64 DOMStorageValuesMap values;
65 ReadAllValues(&values); 65 ReadAllValues(&values);
66 EXPECT_EQ(1u, values.size()); 66 EXPECT_EQ(1u, values.size());
67 EXPECT_EQ(kValue, values[kKey].string()); 67 EXPECT_EQ(kValue, values[kKey].string());
68 } 68 }
69 }; 69 };
70 70
71 private: 71 private:
(...skipping 394 matching lines...) Expand 10 before | Expand all | Expand 10 after
466 EXPECT_EQ( 466 EXPECT_EQ(
467 base::FilePath().AppendASCII("-journal"), 467 base::FilePath().AppendASCII("-journal"),
468 DOMStorageDatabase::GetJournalFilePath(base::FilePath())); 468 DOMStorageDatabase::GetJournalFilePath(base::FilePath()));
469 EXPECT_EQ( 469 EXPECT_EQ(
470 base::FilePath().AppendASCII(".extensiononly-journal"), 470 base::FilePath().AppendASCII(".extensiononly-journal"),
471 DOMStorageDatabase::GetJournalFilePath( 471 DOMStorageDatabase::GetJournalFilePath(
472 base::FilePath().AppendASCII(".extensiononly"))); 472 base::FilePath().AppendASCII(".extensiononly")));
473 } 473 }
474 474
475 } // namespace content 475 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/devtools/tethering_handler.cc ('k') | content/browser/dom_storage/dom_storage_context_wrapper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698