Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Side by Side Diff: content/browser/devtools/tethering_handler.cc

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/devtools/tethering_handler.h" 5 #include "content/browser/devtools/tethering_handler.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/stl_util.h" 9 #include "base/stl_util.h"
10 #include "base/values.h" 10 #include "base/values.h"
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 } 43 }
44 44
45 std::string Init() { 45 std::string Init() {
46 std::string channel_name; 46 std::string channel_name;
47 server_socket_ = delegate_->CreateSocketForTethering(this, &channel_name); 47 server_socket_ = delegate_->CreateSocketForTethering(this, &channel_name);
48 if (!server_socket_.get() || channel_name.empty()) 48 if (!server_socket_.get() || channel_name.empty())
49 SelfDestruct(); 49 SelfDestruct();
50 return channel_name; 50 return channel_name;
51 } 51 }
52 52
53 virtual ~SocketPump() { } 53 ~SocketPump() override {}
54 54
55 private: 55 private:
56 virtual void DidAccept(net::StreamListenSocket* server, 56 void DidAccept(net::StreamListenSocket* server,
57 scoped_ptr<net::StreamListenSocket> socket) override { 57 scoped_ptr<net::StreamListenSocket> socket) override {
58 if (accepted_socket_.get()) 58 if (accepted_socket_.get())
59 return; 59 return;
60 60
61 buffer_ = new net::IOBuffer(kBufferSize); 61 buffer_ = new net::IOBuffer(kBufferSize);
62 wire_buffer_ = new net::GrowableIOBuffer(); 62 wire_buffer_ = new net::GrowableIOBuffer();
63 wire_buffer_->SetCapacity(kBufferSize); 63 wire_buffer_->SetCapacity(kBufferSize);
64 64
65 accepted_socket_ = socket.Pass(); 65 accepted_socket_ = socket.Pass();
66 int result = client_socket_->Read( 66 int result = client_socket_->Read(
67 buffer_.get(), 67 buffer_.get(),
68 kBufferSize, 68 kBufferSize,
69 base::Bind(&SocketPump::OnClientRead, base::Unretained(this))); 69 base::Bind(&SocketPump::OnClientRead, base::Unretained(this)));
70 if (result != net::ERR_IO_PENDING) 70 if (result != net::ERR_IO_PENDING)
71 OnClientRead(result); 71 OnClientRead(result);
72 } 72 }
73 73
74 virtual void DidRead(net::StreamListenSocket* socket, 74 void DidRead(net::StreamListenSocket* socket,
75 const char* data, 75 const char* data,
76 int len) override { 76 int len) override {
77 int old_size = wire_buffer_size_; 77 int old_size = wire_buffer_size_;
78 wire_buffer_size_ += len; 78 wire_buffer_size_ += len;
79 while (wire_buffer_->capacity() < wire_buffer_size_) 79 while (wire_buffer_->capacity() < wire_buffer_size_)
80 wire_buffer_->SetCapacity(wire_buffer_->capacity() * 2); 80 wire_buffer_->SetCapacity(wire_buffer_->capacity() * 2);
81 memcpy(wire_buffer_->StartOfBuffer() + old_size, data, len); 81 memcpy(wire_buffer_->StartOfBuffer() + old_size, data, len);
82 if (old_size != wire_buffer_->offset()) 82 if (old_size != wire_buffer_->offset())
83 return; 83 return;
84 OnClientWrite(0); 84 OnClientWrite(0);
85 } 85 }
86 86
87 virtual void DidClose(net::StreamListenSocket* socket) override { 87 void DidClose(net::StreamListenSocket* socket) override { SelfDestruct(); }
88 SelfDestruct();
89 }
90 88
91 void OnClientRead(int result) { 89 void OnClientRead(int result) {
92 if (result <= 0) { 90 if (result <= 0) {
93 SelfDestruct(); 91 SelfDestruct();
94 return; 92 return;
95 } 93 }
96 94
97 accepted_socket_->Send(buffer_->data(), result); 95 accepted_socket_->Send(buffer_->data(), result);
98 result = client_socket_->Read( 96 result = client_socket_->Read(
99 buffer_.get(), 97 buffer_.get(),
(...skipping 334 matching lines...) Expand 10 before | Expand all | Expand 10 after
434 SendAsyncResponse(command->SuccessResponse(nullptr)); 432 SendAsyncResponse(command->SuccessResponse(nullptr));
435 } 433 }
436 434
437 void TetheringHandler::SendInternalError( 435 void TetheringHandler::SendInternalError(
438 scoped_refptr<DevToolsProtocol::Command> command, 436 scoped_refptr<DevToolsProtocol::Command> command,
439 const std::string& message) { 437 const std::string& message) {
440 SendAsyncResponse(command->InternalErrorResponse(message)); 438 SendAsyncResponse(command->InternalErrorResponse(message));
441 } 439 }
442 440
443 } // namespace content 441 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/devtools/tethering_handler.h ('k') | content/browser/dom_storage/dom_storage_area_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698