Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: content/browser/devtools/devtools_http_handler_impl.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_HTTP_HANDLER_IMPL_H_ 5 #ifndef CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_HTTP_HANDLER_IMPL_H_
6 #define CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_HTTP_HANDLER_IMPL_H_ 6 #define CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_HTTP_HANDLER_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 30 matching lines...) Expand all
41 private: 41 private:
42 friend class base::RefCountedThreadSafe<DevToolsHttpHandlerImpl>; 42 friend class base::RefCountedThreadSafe<DevToolsHttpHandlerImpl>;
43 friend class DevToolsHttpHandler; 43 friend class DevToolsHttpHandler;
44 44
45 class BrowserTarget; 45 class BrowserTarget;
46 46
47 DevToolsHttpHandlerImpl(scoped_ptr<ServerSocketFactory> server_socket_factory, 47 DevToolsHttpHandlerImpl(scoped_ptr<ServerSocketFactory> server_socket_factory,
48 const std::string& frontend_url, 48 const std::string& frontend_url,
49 DevToolsHttpHandlerDelegate* delegate, 49 DevToolsHttpHandlerDelegate* delegate,
50 const base::FilePath& active_port_output_directory); 50 const base::FilePath& active_port_output_directory);
51 virtual ~DevToolsHttpHandlerImpl(); 51 ~DevToolsHttpHandlerImpl() override;
52 void Start(); 52 void Start();
53 53
54 // DevToolsHttpHandler implementation. 54 // DevToolsHttpHandler implementation.
55 virtual void Stop() override; 55 void Stop() override;
56 virtual GURL GetFrontendURL() override; 56 GURL GetFrontendURL() override;
57 57
58 // net::HttpServer::Delegate implementation. 58 // net::HttpServer::Delegate implementation.
59 virtual void OnConnect(int connection_id) override {} 59 void OnConnect(int connection_id) override {}
60 virtual void OnHttpRequest(int connection_id, 60 void OnHttpRequest(int connection_id,
61 const net::HttpServerRequestInfo& info) override; 61 const net::HttpServerRequestInfo& info) override;
62 virtual void OnWebSocketRequest( 62 void OnWebSocketRequest(int connection_id,
63 int connection_id, 63 const net::HttpServerRequestInfo& info) override;
64 const net::HttpServerRequestInfo& info) override; 64 void OnWebSocketMessage(int connection_id, const std::string& data) override;
65 virtual void OnWebSocketMessage(int connection_id, 65 void OnClose(int connection_id) override;
66 const std::string& data) override;
67 virtual void OnClose(int connection_id) override;
68 66
69 void OnJsonRequestUI(int connection_id, 67 void OnJsonRequestUI(int connection_id,
70 const net::HttpServerRequestInfo& info); 68 const net::HttpServerRequestInfo& info);
71 void OnThumbnailRequestUI(int connection_id, const GURL& page_url); 69 void OnThumbnailRequestUI(int connection_id, const GURL& page_url);
72 void OnDiscoveryPageRequestUI(int connection_id); 70 void OnDiscoveryPageRequestUI(int connection_id);
73 71
74 void OnWebSocketRequestUI(int connection_id, 72 void OnWebSocketRequestUI(int connection_id,
75 const net::HttpServerRequestInfo& info); 73 const net::HttpServerRequestInfo& info);
76 void OnWebSocketMessageUI(int connection_id, const std::string& data); 74 void OnWebSocketMessageUI(int connection_id, const std::string& data);
77 void OnCloseUI(int connection_id); 75 void OnCloseUI(int connection_id);
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 typedef std::map<std::string, DevToolsTarget*> TargetMap; 126 typedef std::map<std::string, DevToolsTarget*> TargetMap;
129 TargetMap target_map_; 127 TargetMap target_map_;
130 typedef std::map<int, BrowserTarget*> BrowserTargets; 128 typedef std::map<int, BrowserTarget*> BrowserTargets;
131 BrowserTargets browser_targets_; 129 BrowserTargets browser_targets_;
132 DISALLOW_COPY_AND_ASSIGN(DevToolsHttpHandlerImpl); 130 DISALLOW_COPY_AND_ASSIGN(DevToolsHttpHandlerImpl);
133 }; 131 };
134 132
135 } // namespace content 133 } // namespace content
136 134
137 #endif // CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_HTTP_HANDLER_IMPL_H_ 135 #endif // CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_HTTP_HANDLER_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/devtools/devtools_frontend_host_impl.h ('k') | content/browser/devtools/devtools_http_handler_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698