Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: content/browser/browser_thread_impl.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/browser_process_sub_thread.h ('k') | content/browser/browser_thread_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_BROWSER_THREAD_IMPL_H_ 5 #ifndef CONTENT_BROWSER_BROWSER_THREAD_IMPL_H_
6 #define CONTENT_BROWSER_BROWSER_THREAD_IMPL_H_ 6 #define CONTENT_BROWSER_BROWSER_THREAD_IMPL_H_
7 7
8 #include "base/threading/thread.h" 8 #include "base/threading/thread.h"
9 #include "content/common/content_export.h" 9 #include "content/common/content_export.h"
10 #include "content/public/browser/browser_thread.h" 10 #include "content/public/browser/browser_thread.h"
11 11
12 namespace content { 12 namespace content {
13 13
14 class CONTENT_EXPORT BrowserThreadImpl : public BrowserThread, 14 class CONTENT_EXPORT BrowserThreadImpl : public BrowserThread,
15 public base::Thread { 15 public base::Thread {
16 public: 16 public:
17 // Construct a BrowserThreadImpl with the supplied identifier. It is an error 17 // Construct a BrowserThreadImpl with the supplied identifier. It is an error
18 // to construct a BrowserThreadImpl that already exists. 18 // to construct a BrowserThreadImpl that already exists.
19 explicit BrowserThreadImpl(BrowserThread::ID identifier); 19 explicit BrowserThreadImpl(BrowserThread::ID identifier);
20 20
21 // Special constructor for the main (UI) thread and unittests. If a 21 // Special constructor for the main (UI) thread and unittests. If a
22 // |message_loop| is provied, we use a dummy thread here since the main 22 // |message_loop| is provied, we use a dummy thread here since the main
23 // thread already exists. 23 // thread already exists.
24 BrowserThreadImpl(BrowserThread::ID identifier, 24 BrowserThreadImpl(BrowserThread::ID identifier,
25 base::MessageLoop* message_loop); 25 base::MessageLoop* message_loop);
26 virtual ~BrowserThreadImpl(); 26 ~BrowserThreadImpl() override;
27 27
28 static void ShutdownThreadPool(); 28 static void ShutdownThreadPool();
29 29
30 protected: 30 protected:
31 virtual void Init() override; 31 void Init() override;
32 virtual void Run(base::MessageLoop* message_loop) override; 32 void Run(base::MessageLoop* message_loop) override;
33 virtual void CleanUp() override; 33 void CleanUp() override;
34 34
35 private: 35 private:
36 // We implement all the functionality of the public BrowserThread 36 // We implement all the functionality of the public BrowserThread
37 // functions, but state is stored in the BrowserThreadImpl to keep 37 // functions, but state is stored in the BrowserThreadImpl to keep
38 // the API cleaner. Therefore make BrowserThread a friend class. 38 // the API cleaner. Therefore make BrowserThread a friend class.
39 friend class BrowserThread; 39 friend class BrowserThread;
40 40
41 // The following are unique function names that makes it possible to tell 41 // The following are unique function names that makes it possible to tell
42 // the thread id from the callstack alone in crash dumps. 42 // the thread id from the callstack alone in crash dumps.
43 void UIThreadRun(base::MessageLoop* message_loop); 43 void UIThreadRun(base::MessageLoop* message_loop);
(...skipping 20 matching lines...) Expand all
64 static void FlushThreadPoolHelperForTesting(); 64 static void FlushThreadPoolHelperForTesting();
65 65
66 // The identifier of this thread. Only one thread can exist with a given 66 // The identifier of this thread. Only one thread can exist with a given
67 // identifier at a given time. 67 // identifier at a given time.
68 ID identifier_; 68 ID identifier_;
69 }; 69 };
70 70
71 } // namespace content 71 } // namespace content
72 72
73 #endif // CONTENT_BROWSER_BROWSER_THREAD_IMPL_H_ 73 #endif // CONTENT_BROWSER_BROWSER_THREAD_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/browser_process_sub_thread.h ('k') | content/browser/browser_thread_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698