Standardize usage of virtual/override/final in content/browser/

content/browser/appcache/appcache_service_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/appcache/appcache_service_impl.h"
 
 #include <functional>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 33 matching lines @@
 
 class AppCacheServiceImpl::AsyncHelper
     : public AppCacheStorage::Delegate {
  public:
   AsyncHelper(AppCacheServiceImpl* service,
               const net::CompletionCallback& callback)
       : service_(service), callback_(callback) {
     service_->pending_helpers_.insert(this);
   }
 
-  virtual ~AsyncHelper() {
+  ~AsyncHelper() override {
     if (service_)
       service_->pending_helpers_.erase(this);
   }
 
   virtual void Start() = 0;
   virtual void Cancel();
 
  protected:
   void CallCallback(int rv) {
     if (!callback_.is_null()) {
@@ skipping 22 matching lines @@
 class AppCacheServiceImpl::CanHandleOfflineHelper : AsyncHelper {
  public:
   CanHandleOfflineHelper(
       AppCacheServiceImpl* service, const GURL& url,
       const GURL& first_party, const net::CompletionCallback& callback)
       : AsyncHelper(service, callback),
         url_(url),
         first_party_(first_party) {
   }
 
-  virtual void Start() override {
+  void Start() override {
     AppCachePolicy* policy = service_->appcache_policy();
     if (policy && !policy->CanLoadAppCache(url_, first_party_)) {
       CallCallback(net::ERR_FAILED);
       delete this;
       return;
     }
 
     service_->storage()->FindResponseForMainRequest(url_, GURL(), this);
   }
 
  private:
   // AppCacheStorage::Delegate implementation.
-  virtual void OnMainResponseFound(
-      const GURL& url, const AppCacheEntry& entry,
-      const GURL& fallback_url, const AppCacheEntry& fallback_entry,
-      int64 cache_id, int64 group_id, const GURL& mainfest_url) override;
+  void OnMainResponseFound(const GURL& url,
+                           const AppCacheEntry& entry,
+                           const GURL& fallback_url,
+                           const AppCacheEntry& fallback_entry,
+                           int64 cache_id,
+                           int64 group_id,
+                           const GURL& mainfest_url) override;
 
   GURL url_;
   GURL first_party_;
 
   DISALLOW_COPY_AND_ASSIGN(CanHandleOfflineHelper);
 };
 
 void AppCacheServiceImpl::CanHandleOfflineHelper::OnMainResponseFound(
       const GURL& url, const AppCacheEntry& entry,
       const GURL& fallback_url, const AppCacheEntry& fallback_entry,
       int64 cache_id, int64 group_id, const GURL& manifest_url) {
   bool can = (entry.has_response_id() || fallback_entry.has_response_id());
   CallCallback(can ? net::OK : net::ERR_FAILED);
   delete this;
 }
 
 // DeleteHelper -------
 
 class AppCacheServiceImpl::DeleteHelper : public AsyncHelper {
  public:
   DeleteHelper(
       AppCacheServiceImpl* service, const GURL& manifest_url,
       const net::CompletionCallback& callback)
       : AsyncHelper(service, callback), manifest_url_(manifest_url) {
   }
 
-  virtual void Start() override {
+  void Start() override {
     service_->storage()->LoadOrCreateGroup(manifest_url_, this);
   }
 
  private:
   // AppCacheStorage::Delegate implementation.
-  virtual void OnGroupLoaded(
-      AppCacheGroup* group, const GURL& manifest_url) override;
-  virtual void OnGroupMadeObsolete(AppCacheGroup* group,
-                                   bool success,
-                                   int response_code) override;
+  void OnGroupLoaded(AppCacheGroup* group, const GURL& manifest_url) override;
+  void OnGroupMadeObsolete(AppCacheGroup* group,
+                           bool success,
+                           int response_code) override;
 
   GURL manifest_url_;
   DISALLOW_COPY_AND_ASSIGN(DeleteHelper);
 };
 
 void AppCacheServiceImpl::DeleteHelper::OnGroupLoaded(
       AppCacheGroup* group, const GURL& manifest_url) {
   if (group) {
     group->set_being_deleted(true);
     group->CancelUpdate();
@@ skipping 16 matching lines @@
 
 class AppCacheServiceImpl::DeleteOriginHelper : public AsyncHelper {
  public:
   DeleteOriginHelper(
       AppCacheServiceImpl* service, const GURL& origin,
       const net::CompletionCallback& callback)
       : AsyncHelper(service, callback), origin_(origin),
         num_caches_to_delete_(0), successes_(0), failures_(0) {
   }
 
-  virtual void Start() override {
+  void Start() override {
     // We start by listing all caches, continues in OnAllInfo().
     service_->storage()->GetAllInfo(this);
   }
 
  private:
   // AppCacheStorage::Delegate implementation.
-  virtual void OnAllInfo(AppCacheInfoCollection* collection) override;
-  virtual void OnGroupLoaded(
-      AppCacheGroup* group, const GURL& manifest_url) override;
-  virtual void OnGroupMadeObsolete(AppCacheGroup* group,
-                                   bool success,
-                                   int response_code) override;
+  void OnAllInfo(AppCacheInfoCollection* collection) override;
+  void OnGroupLoaded(AppCacheGroup* group, const GURL& manifest_url) override;
+  void OnGroupMadeObsolete(AppCacheGroup* group,
+                           bool success,
+                           int response_code) override;
 
   void CacheCompleted(bool success);
 
   GURL origin_;
   int num_caches_to_delete_;
   int successes_;
   int failures_;
 
   DISALLOW_COPY_AND_ASSIGN(DeleteOriginHelper);
 };
@@ skipping 61 matching lines @@
 // GetInfoHelper -------
 
 class AppCacheServiceImpl::GetInfoHelper : AsyncHelper {
  public:
   GetInfoHelper(
       AppCacheServiceImpl* service, AppCacheInfoCollection* collection,
       const net::CompletionCallback& callback)
       : AsyncHelper(service, callback), collection_(collection) {
   }
 
-  virtual void Start() override {
-    service_->storage()->GetAllInfo(this);
-  }
+  void Start() override { service_->storage()->GetAllInfo(this); }
 
  private:
   // AppCacheStorage::Delegate implementation.
-  virtual void OnAllInfo(AppCacheInfoCollection* collection) override;
+  void OnAllInfo(AppCacheInfoCollection* collection) override;
 
   scoped_refptr<AppCacheInfoCollection> collection_;
 
   DISALLOW_COPY_AND_ASSIGN(GetInfoHelper);
 };
 
 void AppCacheServiceImpl::GetInfoHelper::OnAllInfo(
       AppCacheInfoCollection* collection) {
   if (collection)
     collection->infos_by_origin.swap(collection_->infos_by_origin);
@@ skipping 11 matching lines @@
       : AsyncHelper(service, net::CompletionCallback()),
         manifest_url_(manifest_url),
         cache_id_(cache_id),
         response_id_(response_id),
         kIOBufferSize(32 * 1024),
         expected_total_size_(0),
         amount_headers_read_(0),
         amount_data_read_(0) {
   }
 
-  virtual void Start() override {
+  void Start() override {
     service_->storage()->LoadOrCreateGroup(manifest_url_, this);
   }
 
-  virtual void Cancel() override {
+  void Cancel() override {
     AppCacheHistograms::CountCheckResponseResult(
         AppCacheHistograms::CHECK_CANCELED);
     response_reader_.reset();
     AsyncHelper::Cancel();
   }
 
  private:
-  virtual void OnGroupLoaded(AppCacheGroup* group,
-                             const GURL& manifest_url) override;
+  void OnGroupLoaded(AppCacheGroup* group, const GURL& manifest_url) override;
   void OnReadInfoComplete(int result);
   void OnReadDataComplete(int result);
 
   // Inputs describing what to check.
   GURL manifest_url_;
   int64 cache_id_;
   int64 response_id_;
 
   // Internals used to perform the checks.
   const int kIOBufferSize;
@@ skipping 230 matching lines @@
   backends_.insert(
       BackendMap::value_type(backend_impl->process_id(), backend_impl));
 }
 
 void AppCacheServiceImpl::UnregisterBackend(
     AppCacheBackendImpl* backend_impl) {
   backends_.erase(backend_impl->process_id());
 }
 
 }  // namespace content