Standardize usage of virtual/override/final in content/browser/

content/browser/appcache/appcache_request_handler_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stack>
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 17 matching lines @@
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace content {
 
 static const int kMockProcessId = 1;
 
 class AppCacheRequestHandlerTest : public testing::Test {
  public:
   class MockFrontend : public AppCacheFrontend {
    public:
-    virtual void OnCacheSelected(
-        int host_id, const AppCacheInfo& info) override {}
+    void OnCacheSelected(int host_id, const AppCacheInfo& info) override {}
 
-    virtual void OnStatusChanged(const std::vector<int>& host_ids,
-                                 AppCacheStatus status) override {}
+    void OnStatusChanged(const std::vector<int>& host_ids,
+                         AppCacheStatus status) override {}
 
-    virtual void OnEventRaised(const std::vector<int>& host_ids,
-                               AppCacheEventID event_id) override {}
+    void OnEventRaised(const std::vector<int>& host_ids,
+                       AppCacheEventID event_id) override {}
 
-    virtual void OnErrorEventRaised(
-        const std::vector<int>& host_ids,
-        const AppCacheErrorDetails& details) override {}
+    void OnErrorEventRaised(const std::vector<int>& host_ids,
+                            const AppCacheErrorDetails& details) override {}
 
-    virtual void OnProgressEventRaised(const std::vector<int>& host_ids,
-                                       const GURL& url,
-                                       int num_total,
-                                       int num_complete) override {
-    }
+    void OnProgressEventRaised(const std::vector<int>& host_ids,
+                               const GURL& url,
+                               int num_total,
+                               int num_complete) override {}
 
-    virtual void OnLogMessage(int host_id,
-                              AppCacheLogLevel log_level,
-                              const std::string& message) override {
-    }
+    void OnLogMessage(int host_id,
+                      AppCacheLogLevel log_level,
+                      const std::string& message) override {}
 
-    virtual void OnContentBlocked(int host_id,
-                                  const GURL& manifest_url) override {}
+    void OnContentBlocked(int host_id, const GURL& manifest_url) override {}
   };
 
   // Helper callback to run a test on our io_thread. The io_thread is spun up
   // once and reused for all tests.
   template <class Method>
   void MethodWrapper(Method method) {
     SetUpTest();
     (this->*method)();
   }
 
   // Subclasses to simulate particular responses so test cases can
   // exercise fallback code paths.
 
   class MockURLRequestDelegate : public net::URLRequest::Delegate {
-    virtual void OnResponseStarted(net::URLRequest* request) override {}
-    virtual void OnReadCompleted(net::URLRequest* request,
-                                 int bytes_read) override {
-    }
+    void OnResponseStarted(net::URLRequest* request) override {}
+    void OnReadCompleted(net::URLRequest* request, int bytes_read) override {}
   };
 
   class MockURLRequestJob : public net::URLRequestJob {
    public:
     MockURLRequestJob(net::URLRequest* request,
                       net::NetworkDelegate* network_delegate,
                       int response_code)
         : net::URLRequestJob(request, network_delegate),
           response_code_(response_code),
           has_response_info_(false) {}
     MockURLRequestJob(net::URLRequest* request,
                       net::NetworkDelegate* network_delegate,
                       const net::HttpResponseInfo& info)
         : net::URLRequestJob(request, network_delegate),
           response_code_(info.headers->response_code()),
           has_response_info_(true),
           response_info_(info) {}
 
    protected:
-    virtual ~MockURLRequestJob() {}
-    virtual void Start() override {
-      NotifyHeadersComplete();
-    }
-    virtual int GetResponseCode() const override {
-      return response_code_;
-    }
-    virtual void GetResponseInfo(
-        net::HttpResponseInfo* info) override {
+    ~MockURLRequestJob() override {}
+    void Start() override { NotifyHeadersComplete(); }
+    int GetResponseCode() const override { return response_code_; }
+    void GetResponseInfo(net::HttpResponseInfo* info) override {
       if (!has_response_info_)
         return;
       *info = response_info_;
     }
 
    private:
     int response_code_;
     bool has_response_info_;
     net::HttpResponseInfo response_info_;
   };
 
   class MockURLRequestJobFactory : public net::URLRequestJobFactory {
    public:
     MockURLRequestJobFactory() : job_(NULL) {
     }
 
-    virtual ~MockURLRequestJobFactory() {
-      DCHECK(!job_);
-    }
+    ~MockURLRequestJobFactory() override { DCHECK(!job_); }
 
     void SetJob(net::URLRequestJob* job) {
       job_ = job;
     }
 
-    virtual net::URLRequestJob* MaybeCreateJobWithProtocolHandler(
+    net::URLRequestJob* MaybeCreateJobWithProtocolHandler(
         const std::string& scheme,
         net::URLRequest* request,
         net::NetworkDelegate* network_delegate) const override {
       if (job_) {
         net::URLRequestJob* temp = job_;
         job_ = NULL;
         return temp;
       } else {
         // Some of these tests trigger UpdateJobs which start URLRequests.
         // We short circuit those be returning error jobs.
         return new net::URLRequestErrorJob(request,
                                            network_delegate,
                                            net::ERR_INTERNET_DISCONNECTED);
       }
     }
 
-    virtual bool IsHandledProtocol(const std::string& scheme) const override {
+    bool IsHandledProtocol(const std::string& scheme) const override {
       return scheme == "http";
     };
 
-    virtual bool IsHandledURL(const GURL& url) const override {
+    bool IsHandledURL(const GURL& url) const override {
       return url.SchemeIs("http");
     }
 
-    virtual bool IsSafeRedirectTarget(const GURL& location) const override {
+    bool IsSafeRedirectTarget(const GURL& location) const override {
       return false;
     }
 
    private:
     mutable net::URLRequestJob* job_;
   };
 
   static void SetUpTestCase() {
     io_thread_.reset(new base::Thread("AppCacheRequestHandlerTest Thread"));
     base::Thread::Options options(base::MessageLoop::TYPE_IO, 0);
@@ skipping 832 matching lines @@
 
 TEST_F(AppCacheRequestHandlerTest, WorkerRequest) {
   RunTestOnIOThread(&AppCacheRequestHandlerTest::WorkerRequest);
 }
 
 TEST_F(AppCacheRequestHandlerTest, MainResource_Blocked) {
   RunTestOnIOThread(&AppCacheRequestHandlerTest::MainResource_Blocked);
 }
 
 }  // namespace content