Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 667933002: [x86] Select better left operand for comparisons. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
Reviewers:
dcarney
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[x86] Select better left operand for comparisons. R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24764

Patch Set 1 #

Patch Set 2 : REBASE #

Patch Set 3 : Correctify VisitWordCompare. #

Patch Set 4 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -68 lines) Patch
M src/compiler/ia32/instruction-selector-ia32.cc View 1 2 3 6 chunks +38 lines, -31 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 2 3 6 chunks +47 lines, -37 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
6 years, 2 months ago (2014-10-21 09:46:54 UTC) #1
dcarney
lgtm
6 years, 2 months ago (2014-10-21 10:04:24 UTC) #2
Benedikt Meurer
6 years, 2 months ago (2014-10-21 11:00:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 24764 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698