net/udp/udp_socket_libevent.h - Issue 667923003: Standardize usage of virtual/override/final in net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/udp/udp_socket_libevent.h

Issue 667923003: Standardize usage of virtual/override/final in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/udp/udp_socket_libevent.h

diff --git a/net/udp/udp_socket_libevent.h b/net/udp/udp_socket_libevent.h

index 292a42fa80679bfab9a950462d22f84c6ad77042..2ac564debc533752d038b81a9b76312ecf0cc920 100644

--- a/net/udp/udp_socket_libevent.h

+++ b/net/udp/udp_socket_libevent.h

@@ -179,9 +179,9 @@ class NET_EXPORT UDPSocketLibevent : public base::NonThreadSafe {

// MessageLoopForIO::Watcher methods

- virtual void OnFileCanReadWithoutBlocking(int /* fd */) override;

+ void OnFileCanReadWithoutBlocking(int /* fd */) override;

- virtual void OnFileCanWriteWithoutBlocking(int /* fd */) override {}

+ void OnFileCanWriteWithoutBlocking(int /* fd */) override {}

private:

UDPSocketLibevent* const socket_;

@@ -195,9 +195,9 @@ class NET_EXPORT UDPSocketLibevent : public base::NonThreadSafe {

// MessageLoopForIO::Watcher methods

- virtual void OnFileCanReadWithoutBlocking(int /* fd */) override {}

+ void OnFileCanReadWithoutBlocking(int /* fd */) override {}

- virtual void OnFileCanWriteWithoutBlocking(int /* fd */) override;

+ void OnFileCanWriteWithoutBlocking(int /* fd */) override;

private:

UDPSocketLibevent* const socket_;

« no previous file with comments | « net/udp/udp_server_socket.h ('k') | net/url_request/data_protocol_handler.h » ('j') | no next file with comments »