net/test/spawned_test_server/local_test_server_posix.cc - Issue 667923003: Standardize usage of virtual/override/final in net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/test/spawned_test_server/local_test_server_posix.cc

Issue 667923003: Standardize usage of virtual/override/final in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/test/spawned_test_server/local_test_server_posix.cc

diff --git a/net/test/spawned_test_server/local_test_server_posix.cc b/net/test/spawned_test_server/local_test_server_posix.cc

index 64c9b442c122ed427c4ca9fca4644f47ee829632..0edbedf1e42b8f120ab7793e1dc303a351c6fa31 100644

--- a/net/test/spawned_test_server/local_test_server_posix.cc

+++ b/net/test/spawned_test_server/local_test_server_posix.cc

@@ -34,7 +34,7 @@ class OrphanedTestServerFilter : public base::ProcessFilter {

: path_string_(path_string),

port_string_(port_string) {}

- virtual bool Includes(const base::ProcessEntry& entry) const override {

+ bool Includes(const base::ProcessEntry& entry) const override {

if (entry.parent_pid() != 1)

return false;

bool found_path_string = false;