net/disk_cache/blockfile/entry_impl.cc - Issue 667923003: Standardize usage of virtual/override/final in net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/blockfile/entry_impl.cc

Issue 667923003: Standardize usage of virtual/override/final in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/disk_cache/blockfile/entry_impl.cc

diff --git a/net/disk_cache/blockfile/entry_impl.cc b/net/disk_cache/blockfile/entry_impl.cc

index 2b9847081e95c92662be93e0e96dcee6a4498753..0a882dec6e6aa5b085af232e71fc7fb73fb8cf12 100644

--- a/net/disk_cache/blockfile/entry_impl.cc

+++ b/net/disk_cache/blockfile/entry_impl.cc

@@ -44,9 +44,9 @@ class SyncCallback: public disk_cache::FileIOCallback {

entry->AddRef();

entry->IncrementIoCount();

}

- virtual ~SyncCallback() {}

+ ~SyncCallback() override {}

- virtual void OnFileIOComplete(int bytes_copied) override;

+ void OnFileIOComplete(int bytes_copied) override;

void Discard();

private:

« no previous file with comments | « net/disk_cache/blockfile/entry_impl.h ('k') | net/disk_cache/blockfile/entry_impl_v3.h » ('j') | no next file with comments »