net/websockets/websocket_basic_stream_test.cc - Issue 667923003: Standardize usage of virtual/override/final in net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/websockets/websocket_basic_stream_test.cc

Issue 667923003: Standardize usage of virtual/override/final in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/websockets/websocket_basic_stream_test.cc

diff --git a/net/websockets/websocket_basic_stream_test.cc b/net/websockets/websocket_basic_stream_test.cc

index a658fcf311eaa06663e4281e08043dea4592fb82..92b7d3f88d45dfcf43e4abdcc13e87f6bf213d18 100644

--- a/net/websockets/websocket_basic_stream_test.cc

+++ b/net/websockets/websocket_basic_stream_test.cc

@@ -90,7 +90,7 @@ class StrictStaticSocketDataProvider : public StaticSocketDataProvider {

: StaticSocketDataProvider(reads, reads_count, writes, writes_count),

strict_mode_(strict_mode) {}

- virtual ~StrictStaticSocketDataProvider() {

+ ~StrictStaticSocketDataProvider() override {

if (strict_mode_) {

EXPECT_EQ(read_count(), read_index());

EXPECT_EQ(write_count(), write_index());

« no previous file with comments | « net/websockets/websocket_basic_stream.h ('k') | net/websockets/websocket_channel.cc » ('j') | no next file with comments »