net/socket/client_socket_pool.h - Issue 667923003: Standardize usage of virtual/override/final in net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/client_socket_pool.h

Issue 667923003: Standardize usage of virtual/override/final in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/client_socket_pool.h

diff --git a/net/socket/client_socket_pool.h b/net/socket/client_socket_pool.h

index 715cddb94d484d3b2ef0057c24b5aa4604597c35..2a2be36c8cdaabf7ec674f4a18823302e5b16527 100644

--- a/net/socket/client_socket_pool.h

+++ b/net/socket/client_socket_pool.h

@@ -182,7 +182,7 @@ class NET_EXPORT ClientSocketPool : public LowerLayeredPool {

protected:

ClientSocketPool();

- virtual ~ClientSocketPool();

+ ~ClientSocketPool() override;

// Return the connection timeout for this pool.

virtual base::TimeDelta ConnectionTimeout() const = 0;

« no previous file with comments | « net/socket/client_socket_factory.cc ('k') | net/socket/client_socket_pool_base.h » ('j') | no next file with comments »