net/quic/crypto/quic_crypto_server_config.cc - Issue 667923003: Standardize usage of virtual/override/final in net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/crypto/quic_crypto_server_config.cc

Issue 667923003: Standardize usage of virtual/override/final in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/crypto/quic_crypto_server_config.cc

diff --git a/net/quic/crypto/quic_crypto_server_config.cc b/net/quic/crypto/quic_crypto_server_config.cc

index d5a2b75d2a91600d52fd5ac45cc16f34018dcfc8..08cdb7e6290dc849e79c115583b62a874fe8df6a 100644

--- a/net/quic/crypto/quic_crypto_server_config.cc

+++ b/net/quic/crypto/quic_crypto_server_config.cc

@@ -107,8 +107,8 @@ class VerifyNonceIsValidAndUniqueCallback

}

protected:

- virtual void RunImpl(bool nonce_is_valid_and_unique,

- InsertStatus nonce_error) override {

+ void RunImpl(bool nonce_is_valid_and_unique,

+ InsertStatus nonce_error) override {

DVLOG(1) << "Using client nonce, unique: " << nonce_is_valid_and_unique

<< " nonce_error: " << nonce_error;

result_->info.unique = nonce_is_valid_and_unique;