net/spdy/spdy_stream.cc - Issue 667923003: Standardize usage of virtual/override/final in net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_stream.cc

Issue 667923003: Standardize usage of virtual/override/final in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_stream.cc

diff --git a/net/spdy/spdy_stream.cc b/net/spdy/spdy_stream.cc

index 6de0a395da14a708dc9d1f7e7512c48bf0609d19..e7dcd5b95d5e2aa82c5e47a0cb50058e98ec514a 100644

--- a/net/spdy/spdy_stream.cc

+++ b/net/spdy/spdy_stream.cc

@@ -61,9 +61,9 @@ class SpdyStream::SynStreamBufferProducer : public SpdyBufferProducer {

DCHECK(stream_.get());

}

- virtual ~SynStreamBufferProducer() {}

+ ~SynStreamBufferProducer() override {}

- virtual scoped_ptr<SpdyBuffer> ProduceBuffer() override {

+ scoped_ptr<SpdyBuffer> ProduceBuffer() override {

if (!stream_.get()) {

NOTREACHED();

return scoped_ptr<SpdyBuffer>();

« no previous file with comments | « net/spdy/spdy_session_unittest.cc ('k') | net/spdy/spdy_stream_test_util.h » ('j') | no next file with comments »