net/proxy/network_delegate_error_observer.h - Issue 667923003: Standardize usage of virtual/override/final in net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/network_delegate_error_observer.h

Issue 667923003: Standardize usage of virtual/override/final in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/proxy/network_delegate_error_observer.h

diff --git a/net/proxy/network_delegate_error_observer.h b/net/proxy/network_delegate_error_observer.h

index 70a2bedbaf29e68aaeb8d9afb69753df8938ede7..6fad5780175974502b1a268806d010f6a2a8a750 100644

--- a/net/proxy/network_delegate_error_observer.h

+++ b/net/proxy/network_delegate_error_observer.h

@@ -24,11 +24,10 @@ class NET_EXPORT_PRIVATE NetworkDelegateErrorObserver

public:

NetworkDelegateErrorObserver(NetworkDelegate* network_delegate,

base::MessageLoopProxy* origin_loop);

- virtual ~NetworkDelegateErrorObserver();

+ ~NetworkDelegateErrorObserver() override;

// ProxyResolverErrorObserver implementation.

- virtual void OnPACScriptError(int line_number, const base::string16& error)

- override;

+ void OnPACScriptError(int line_number, const base::string16& error) override;

private:

class Core;