Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Side by Side Diff: net/url_request/url_request_context_builder.cc

Issue 667923003: Standardize usage of virtual/override/final in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/url_request/url_request_context_builder.h" 5 #include "net/url_request/url_request_context_builder.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 #include "net/url_request/ftp_protocol_handler.h" 44 #include "net/url_request/ftp_protocol_handler.h"
45 #endif 45 #endif
46 46
47 namespace net { 47 namespace net {
48 48
49 namespace { 49 namespace {
50 50
51 class BasicNetworkDelegate : public NetworkDelegate { 51 class BasicNetworkDelegate : public NetworkDelegate {
52 public: 52 public:
53 BasicNetworkDelegate() {} 53 BasicNetworkDelegate() {}
54 virtual ~BasicNetworkDelegate() {} 54 ~BasicNetworkDelegate() override {}
55 55
56 private: 56 private:
57 virtual int OnBeforeURLRequest(URLRequest* request, 57 int OnBeforeURLRequest(URLRequest* request,
58 const CompletionCallback& callback, 58 const CompletionCallback& callback,
59 GURL* new_url) override { 59 GURL* new_url) override {
60 return OK; 60 return OK;
61 } 61 }
62 62
63 virtual int OnBeforeSendHeaders(URLRequest* request, 63 int OnBeforeSendHeaders(URLRequest* request,
64 const CompletionCallback& callback, 64 const CompletionCallback& callback,
65 HttpRequestHeaders* headers) override { 65 HttpRequestHeaders* headers) override {
66 return OK; 66 return OK;
67 } 67 }
68 68
69 virtual void OnSendHeaders(URLRequest* request, 69 void OnSendHeaders(URLRequest* request,
70 const HttpRequestHeaders& headers) override {} 70 const HttpRequestHeaders& headers) override {}
71 71
72 virtual int OnHeadersReceived( 72 int OnHeadersReceived(
73 URLRequest* request, 73 URLRequest* request,
74 const CompletionCallback& callback, 74 const CompletionCallback& callback,
75 const HttpResponseHeaders* original_response_headers, 75 const HttpResponseHeaders* original_response_headers,
76 scoped_refptr<HttpResponseHeaders>* override_response_headers, 76 scoped_refptr<HttpResponseHeaders>* override_response_headers,
77 GURL* allowed_unsafe_redirect_url) override { 77 GURL* allowed_unsafe_redirect_url) override {
78 return OK; 78 return OK;
79 } 79 }
80 80
81 virtual void OnBeforeRedirect(URLRequest* request, 81 void OnBeforeRedirect(URLRequest* request,
82 const GURL& new_location) override {} 82 const GURL& new_location) override {}
83 83
84 virtual void OnResponseStarted(URLRequest* request) override {} 84 void OnResponseStarted(URLRequest* request) override {}
85 85
86 virtual void OnRawBytesRead(const URLRequest& request, 86 void OnRawBytesRead(const URLRequest& request, int bytes_read) override {}
87 int bytes_read) override {}
88 87
89 virtual void OnCompleted(URLRequest* request, bool started) override {} 88 void OnCompleted(URLRequest* request, bool started) override {}
90 89
91 virtual void OnURLRequestDestroyed(URLRequest* request) override {} 90 void OnURLRequestDestroyed(URLRequest* request) override {}
92 91
93 virtual void OnPACScriptError(int line_number, 92 void OnPACScriptError(int line_number, const base::string16& error) override {
94 const base::string16& error) override {} 93 }
95 94
96 virtual NetworkDelegate::AuthRequiredResponse OnAuthRequired( 95 NetworkDelegate::AuthRequiredResponse OnAuthRequired(
97 URLRequest* request, 96 URLRequest* request,
98 const AuthChallengeInfo& auth_info, 97 const AuthChallengeInfo& auth_info,
99 const AuthCallback& callback, 98 const AuthCallback& callback,
100 AuthCredentials* credentials) override { 99 AuthCredentials* credentials) override {
101 return NetworkDelegate::AUTH_REQUIRED_RESPONSE_NO_ACTION; 100 return NetworkDelegate::AUTH_REQUIRED_RESPONSE_NO_ACTION;
102 } 101 }
103 102
104 virtual bool OnCanGetCookies(const URLRequest& request, 103 bool OnCanGetCookies(const URLRequest& request,
105 const CookieList& cookie_list) override { 104 const CookieList& cookie_list) override {
106 return true; 105 return true;
107 } 106 }
108 107
109 virtual bool OnCanSetCookie(const URLRequest& request, 108 bool OnCanSetCookie(const URLRequest& request,
110 const std::string& cookie_line, 109 const std::string& cookie_line,
111 CookieOptions* options) override { 110 CookieOptions* options) override {
112 return true; 111 return true;
113 } 112 }
114 113
115 virtual bool OnCanAccessFile(const net::URLRequest& request, 114 bool OnCanAccessFile(const net::URLRequest& request,
116 const base::FilePath& path) const override { 115 const base::FilePath& path) const override {
117 return true; 116 return true;
118 } 117 }
119 118
120 virtual bool OnCanThrottleRequest(const URLRequest& request) const override { 119 bool OnCanThrottleRequest(const URLRequest& request) const override {
121 // Returning true will only enable throttling if there's also a 120 // Returning true will only enable throttling if there's also a
122 // URLRequestThrottlerManager, which there isn't, by default. 121 // URLRequestThrottlerManager, which there isn't, by default.
123 return true; 122 return true;
124 } 123 }
125 124
126 virtual int OnBeforeSocketStreamConnect( 125 int OnBeforeSocketStreamConnect(SocketStream* stream,
127 SocketStream* stream, 126 const CompletionCallback& callback) override {
128 const CompletionCallback& callback) override {
129 return OK; 127 return OK;
130 } 128 }
131 129
132 DISALLOW_COPY_AND_ASSIGN(BasicNetworkDelegate); 130 DISALLOW_COPY_AND_ASSIGN(BasicNetworkDelegate);
133 }; 131 };
134 132
135 class BasicURLRequestContext : public URLRequestContext { 133 class BasicURLRequestContext : public URLRequestContext {
136 public: 134 public:
137 BasicURLRequestContext() 135 BasicURLRequestContext()
138 : storage_(this) {} 136 : storage_(this) {}
(...skipping 19 matching lines...) Expand all
158 } 156 }
159 return file_thread_.get(); 157 return file_thread_.get();
160 } 158 }
161 159
162 void set_transport_security_persister( 160 void set_transport_security_persister(
163 scoped_ptr<TransportSecurityPersister> transport_security_persister) { 161 scoped_ptr<TransportSecurityPersister> transport_security_persister) {
164 transport_security_persister = transport_security_persister.Pass(); 162 transport_security_persister = transport_security_persister.Pass();
165 } 163 }
166 164
167 protected: 165 protected:
168 virtual ~BasicURLRequestContext() { 166 ~BasicURLRequestContext() override { AssertNoURLRequests(); }
169 AssertNoURLRequests();
170 }
171 167
172 private: 168 private:
173 // Threads should be torn down last. 169 // Threads should be torn down last.
174 scoped_ptr<base::Thread> cache_thread_; 170 scoped_ptr<base::Thread> cache_thread_;
175 scoped_ptr<base::Thread> file_thread_; 171 scoped_ptr<base::Thread> file_thread_;
176 172
177 URLRequestContextStorage storage_; 173 URLRequestContextStorage storage_;
178 scoped_ptr<TransportSecurityPersister> transport_security_persister_; 174 scoped_ptr<TransportSecurityPersister> transport_security_persister_;
179 175
180 DISALLOW_COPY_AND_ASSIGN(BasicURLRequestContext); 176 DISALLOW_COPY_AND_ASSIGN(BasicURLRequestContext);
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
405 #endif // !defined(DISABLE_FTP_SUPPORT) 401 #endif // !defined(DISABLE_FTP_SUPPORT)
406 402
407 storage->set_job_factory(job_factory); 403 storage->set_job_factory(job_factory);
408 404
409 // TODO(willchan): Support sdch. 405 // TODO(willchan): Support sdch.
410 406
411 return context; 407 return context;
412 } 408 }
413 409
414 } // namespace net 410 } // namespace net
OLDNEW
« no previous file with comments | « net/url_request/url_request_about_job.h ('k') | net/url_request/url_request_context_builder_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698