Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: net/quic/test_tools/simple_quic_framer.cc

Issue 667923003: Standardize usage of virtual/override/final in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/test_tools/quic_test_utils.cc ('k') | net/quic/test_tools/test_task_runner.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/test_tools/simple_quic_framer.h" 5 #include "net/quic/test_tools/simple_quic_framer.h"
6 6
7 #include "base/stl_util.h" 7 #include "base/stl_util.h"
8 #include "net/quic/crypto/crypto_framer.h" 8 #include "net/quic/crypto/crypto_framer.h"
9 #include "net/quic/crypto/quic_decrypter.h" 9 #include "net/quic/crypto/quic_decrypter.h"
10 #include "net/quic/crypto/quic_encrypter.h" 10 #include "net/quic/crypto/quic_encrypter.h"
11 11
12 using base::StringPiece; 12 using base::StringPiece;
13 using std::string; 13 using std::string;
14 using std::vector; 14 using std::vector;
15 15
16 namespace net { 16 namespace net {
17 namespace test { 17 namespace test {
18 18
19 class SimpleFramerVisitor : public QuicFramerVisitorInterface { 19 class SimpleFramerVisitor : public QuicFramerVisitorInterface {
20 public: 20 public:
21 SimpleFramerVisitor() 21 SimpleFramerVisitor()
22 : error_(QUIC_NO_ERROR) { 22 : error_(QUIC_NO_ERROR) {
23 } 23 }
24 24
25 virtual ~SimpleFramerVisitor() override { 25 ~SimpleFramerVisitor() override { STLDeleteElements(&stream_data_); }
26 STLDeleteElements(&stream_data_);
27 }
28 26
29 virtual void OnError(QuicFramer* framer) override { 27 void OnError(QuicFramer* framer) override { error_ = framer->error(); }
30 error_ = framer->error();
31 }
32 28
33 virtual bool OnProtocolVersionMismatch(QuicVersion version) override { 29 bool OnProtocolVersionMismatch(QuicVersion version) override { return false; }
34 return false;
35 }
36 30
37 virtual void OnPacket() override {} 31 void OnPacket() override {}
38 virtual void OnPublicResetPacket( 32 void OnPublicResetPacket(const QuicPublicResetPacket& packet) override {
39 const QuicPublicResetPacket& packet) override {
40 public_reset_packet_.reset(new QuicPublicResetPacket(packet)); 33 public_reset_packet_.reset(new QuicPublicResetPacket(packet));
41 } 34 }
42 virtual void OnVersionNegotiationPacket( 35 void OnVersionNegotiationPacket(
43 const QuicVersionNegotiationPacket& packet) override { 36 const QuicVersionNegotiationPacket& packet) override {
44 version_negotiation_packet_.reset( 37 version_negotiation_packet_.reset(
45 new QuicVersionNegotiationPacket(packet)); 38 new QuicVersionNegotiationPacket(packet));
46 } 39 }
47 virtual void OnRevivedPacket() override {} 40 void OnRevivedPacket() override {}
48 41
49 virtual bool OnUnauthenticatedPublicHeader( 42 bool OnUnauthenticatedPublicHeader(
50 const QuicPacketPublicHeader& header) override { 43 const QuicPacketPublicHeader& header) override {
51 return true; 44 return true;
52 } 45 }
53 virtual bool OnUnauthenticatedHeader( 46 bool OnUnauthenticatedHeader(const QuicPacketHeader& header) override {
54 const QuicPacketHeader& header) override {
55 return true; 47 return true;
56 } 48 }
57 virtual void OnDecryptedPacket(EncryptionLevel level) override {} 49 void OnDecryptedPacket(EncryptionLevel level) override {}
58 virtual bool OnPacketHeader(const QuicPacketHeader& header) override { 50 bool OnPacketHeader(const QuicPacketHeader& header) override {
59 has_header_ = true; 51 has_header_ = true;
60 header_ = header; 52 header_ = header;
61 return true; 53 return true;
62 } 54 }
63 55
64 virtual void OnFecProtectedPayload(StringPiece payload) override {} 56 void OnFecProtectedPayload(StringPiece payload) override {}
65 57
66 virtual bool OnStreamFrame(const QuicStreamFrame& frame) override { 58 bool OnStreamFrame(const QuicStreamFrame& frame) override {
67 // Save a copy of the data so it is valid after the packet is processed. 59 // Save a copy of the data so it is valid after the packet is processed.
68 stream_data_.push_back(frame.GetDataAsString()); 60 stream_data_.push_back(frame.GetDataAsString());
69 QuicStreamFrame stream_frame(frame); 61 QuicStreamFrame stream_frame(frame);
70 // Make sure that the stream frame points to this data. 62 // Make sure that the stream frame points to this data.
71 stream_frame.data.Clear(); 63 stream_frame.data.Clear();
72 stream_frame.data.Append(const_cast<char*>(stream_data_.back()->data()), 64 stream_frame.data.Append(const_cast<char*>(stream_data_.back()->data()),
73 stream_data_.back()->size()); 65 stream_data_.back()->size());
74 stream_frames_.push_back(stream_frame); 66 stream_frames_.push_back(stream_frame);
75 return true; 67 return true;
76 } 68 }
77 69
78 virtual bool OnAckFrame(const QuicAckFrame& frame) override { 70 bool OnAckFrame(const QuicAckFrame& frame) override {
79 ack_frames_.push_back(frame); 71 ack_frames_.push_back(frame);
80 return true; 72 return true;
81 } 73 }
82 74
83 virtual bool OnCongestionFeedbackFrame( 75 bool OnCongestionFeedbackFrame(
84 const QuicCongestionFeedbackFrame& frame) override { 76 const QuicCongestionFeedbackFrame& frame) override {
85 feedback_frames_.push_back(frame); 77 feedback_frames_.push_back(frame);
86 return true; 78 return true;
87 } 79 }
88 80
89 virtual bool OnStopWaitingFrame(const QuicStopWaitingFrame& frame) override { 81 bool OnStopWaitingFrame(const QuicStopWaitingFrame& frame) override {
90 stop_waiting_frames_.push_back(frame); 82 stop_waiting_frames_.push_back(frame);
91 return true; 83 return true;
92 } 84 }
93 85
94 virtual bool OnPingFrame(const QuicPingFrame& frame) override { 86 bool OnPingFrame(const QuicPingFrame& frame) override {
95 ping_frames_.push_back(frame); 87 ping_frames_.push_back(frame);
96 return true; 88 return true;
97 } 89 }
98 90
99 virtual void OnFecData(const QuicFecData& fec) override { 91 void OnFecData(const QuicFecData& fec) override {
100 fec_data_ = fec; 92 fec_data_ = fec;
101 fec_redundancy_ = fec_data_.redundancy.as_string(); 93 fec_redundancy_ = fec_data_.redundancy.as_string();
102 fec_data_.redundancy = fec_redundancy_; 94 fec_data_.redundancy = fec_redundancy_;
103 } 95 }
104 96
105 virtual bool OnRstStreamFrame(const QuicRstStreamFrame& frame) override { 97 bool OnRstStreamFrame(const QuicRstStreamFrame& frame) override {
106 rst_stream_frames_.push_back(frame); 98 rst_stream_frames_.push_back(frame);
107 return true; 99 return true;
108 } 100 }
109 101
110 virtual bool OnConnectionCloseFrame( 102 bool OnConnectionCloseFrame(const QuicConnectionCloseFrame& frame) override {
111 const QuicConnectionCloseFrame& frame) override {
112 connection_close_frames_.push_back(frame); 103 connection_close_frames_.push_back(frame);
113 return true; 104 return true;
114 } 105 }
115 106
116 virtual bool OnGoAwayFrame(const QuicGoAwayFrame& frame) override { 107 bool OnGoAwayFrame(const QuicGoAwayFrame& frame) override {
117 goaway_frames_.push_back(frame); 108 goaway_frames_.push_back(frame);
118 return true; 109 return true;
119 } 110 }
120 111
121 virtual bool OnWindowUpdateFrame( 112 bool OnWindowUpdateFrame(const QuicWindowUpdateFrame& frame) override {
122 const QuicWindowUpdateFrame& frame) override {
123 window_update_frames_.push_back(frame); 113 window_update_frames_.push_back(frame);
124 return true; 114 return true;
125 } 115 }
126 116
127 virtual bool OnBlockedFrame(const QuicBlockedFrame& frame) override { 117 bool OnBlockedFrame(const QuicBlockedFrame& frame) override {
128 blocked_frames_.push_back(frame); 118 blocked_frames_.push_back(frame);
129 return true; 119 return true;
130 } 120 }
131 121
132 virtual void OnPacketComplete() override {} 122 void OnPacketComplete() override {}
133 123
134 const QuicPacketHeader& header() const { return header_; } 124 const QuicPacketHeader& header() const { return header_; }
135 const vector<QuicAckFrame>& ack_frames() const { return ack_frames_; } 125 const vector<QuicAckFrame>& ack_frames() const { return ack_frames_; }
136 const vector<QuicConnectionCloseFrame>& connection_close_frames() const { 126 const vector<QuicConnectionCloseFrame>& connection_close_frames() const {
137 return connection_close_frames_; 127 return connection_close_frames_;
138 } 128 }
139 const vector<QuicCongestionFeedbackFrame>& feedback_frames() const { 129 const vector<QuicCongestionFeedbackFrame>& feedback_frames() const {
140 return feedback_frames_; 130 return feedback_frames_;
141 } 131 }
142 const vector<QuicGoAwayFrame>& goaway_frames() const { 132 const vector<QuicGoAwayFrame>& goaway_frames() const {
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
278 return visitor_->goaway_frames(); 268 return visitor_->goaway_frames();
279 } 269 }
280 270
281 const vector<QuicConnectionCloseFrame>& 271 const vector<QuicConnectionCloseFrame>&
282 SimpleQuicFramer::connection_close_frames() const { 272 SimpleQuicFramer::connection_close_frames() const {
283 return visitor_->connection_close_frames(); 273 return visitor_->connection_close_frames();
284 } 274 }
285 275
286 } // namespace test 276 } // namespace test
287 } // namespace net 277 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/test_tools/quic_test_utils.cc ('k') | net/quic/test_tools/test_task_runner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698