Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Side by Side Diff: net/proxy/proxy_resolver_v8.h

Issue 667923003: Standardize usage of virtual/override/final in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/proxy/proxy_resolver_perftest.cc ('k') | net/proxy/proxy_resolver_v8.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_PROXY_PROXY_RESOLVER_V8_H_ 5 #ifndef NET_PROXY_PROXY_RESOLVER_V8_H_
6 #define NET_PROXY_PROXY_RESOLVER_V8_H_ 6 #define NET_PROXY_PROXY_RESOLVER_V8_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "net/base/net_export.h" 10 #include "net/base/net_export.h"
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 // if a line number is not applicable to this error. 69 // if a line number is not applicable to this error.
70 virtual void OnError(int line_number, const base::string16& error) = 0; 70 virtual void OnError(int line_number, const base::string16& error) = 0;
71 71
72 protected: 72 protected:
73 virtual ~JSBindings() {} 73 virtual ~JSBindings() {}
74 }; 74 };
75 75
76 // Constructs a ProxyResolverV8. 76 // Constructs a ProxyResolverV8.
77 ProxyResolverV8(); 77 ProxyResolverV8();
78 78
79 virtual ~ProxyResolverV8(); 79 ~ProxyResolverV8() override;
80 80
81 JSBindings* js_bindings() const { return js_bindings_; } 81 JSBindings* js_bindings() const { return js_bindings_; }
82 void set_js_bindings(JSBindings* js_bindings) { js_bindings_ = js_bindings; } 82 void set_js_bindings(JSBindings* js_bindings) { js_bindings_ = js_bindings; }
83 83
84 // ProxyResolver implementation: 84 // ProxyResolver implementation:
85 virtual int GetProxyForURL(const GURL& url, 85 int GetProxyForURL(const GURL& url,
86 ProxyInfo* results, 86 ProxyInfo* results,
87 const net::CompletionCallback& /*callback*/, 87 const net::CompletionCallback& /*callback*/,
88 RequestHandle* /*request*/, 88 RequestHandle* /*request*/,
89 const BoundNetLog& net_log) override; 89 const BoundNetLog& net_log) override;
90 virtual void CancelRequest(RequestHandle request) override; 90 void CancelRequest(RequestHandle request) override;
91 virtual LoadState GetLoadState(RequestHandle request) const override; 91 LoadState GetLoadState(RequestHandle request) const override;
92 virtual void CancelSetPacScript() override; 92 void CancelSetPacScript() override;
93 virtual int SetPacScript( 93 int SetPacScript(const scoped_refptr<ProxyResolverScriptData>& script_data,
94 const scoped_refptr<ProxyResolverScriptData>& script_data, 94 const net::CompletionCallback& /*callback*/) override;
95 const net::CompletionCallback& /*callback*/) override;
96 95
97 // Create an isolate to use for the proxy resolver. If the embedder invokes 96 // Create an isolate to use for the proxy resolver. If the embedder invokes
98 // this method multiple times, it must be invoked in a thread safe manner, 97 // this method multiple times, it must be invoked in a thread safe manner,
99 // e.g. always from the same thread. 98 // e.g. always from the same thread.
100 static void EnsureIsolateCreated(); 99 static void EnsureIsolateCreated();
101 100
102 static v8::Isolate* GetDefaultIsolate(); 101 static v8::Isolate* GetDefaultIsolate();
103 102
104 // Get total/ued heap memory usage of all v8 instances used by the proxy 103 // Get total/ued heap memory usage of all v8 instances used by the proxy
105 // resolver. 104 // resolver.
(...skipping 11 matching lines...) Expand all
117 scoped_ptr<Context> context_; 116 scoped_ptr<Context> context_;
118 117
119 JSBindings* js_bindings_; 118 JSBindings* js_bindings_;
120 119
121 DISALLOW_COPY_AND_ASSIGN(ProxyResolverV8); 120 DISALLOW_COPY_AND_ASSIGN(ProxyResolverV8);
122 }; 121 };
123 122
124 } // namespace net 123 } // namespace net
125 124
126 #endif // NET_PROXY_PROXY_RESOLVER_V8_H_ 125 #endif // NET_PROXY_PROXY_RESOLVER_V8_H_
OLDNEW
« no previous file with comments | « net/proxy/proxy_resolver_perftest.cc ('k') | net/proxy/proxy_resolver_v8.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698