Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Side by Side Diff: net/proxy/proxy_config_service_mac.h

Issue 667923003: Standardize usage of virtual/override/final in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/proxy/proxy_config_service_fixed.h ('k') | net/proxy/proxy_resolver_mac.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_PROXY_PROXY_CONFIG_SERVICE_MAC_H_ 5 #ifndef NET_PROXY_PROXY_CONFIG_SERVICE_MAC_H_
6 #define NET_PROXY_PROXY_CONFIG_SERVICE_MAC_H_ 6 #define NET_PROXY_PROXY_CONFIG_SERVICE_MAC_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
11 #include "base/memory/scoped_ptr.h" 11 #include "base/memory/scoped_ptr.h"
12 #include "base/observer_list.h" 12 #include "base/observer_list.h"
13 #include "net/base/network_config_watcher_mac.h" 13 #include "net/base/network_config_watcher_mac.h"
14 #include "net/proxy/proxy_config.h" 14 #include "net/proxy/proxy_config.h"
15 #include "net/proxy/proxy_config_service.h" 15 #include "net/proxy/proxy_config_service.h"
16 16
17 namespace base { 17 namespace base {
18 class SingleThreadTaskRunner; 18 class SingleThreadTaskRunner;
19 } // namespace base 19 } // namespace base
20 20
21 namespace net { 21 namespace net {
22 22
23 class ProxyConfigServiceMac : public ProxyConfigService { 23 class ProxyConfigServiceMac : public ProxyConfigService {
24 public: 24 public:
25 // Constructs a ProxyConfigService that watches the Mac OS system settings. 25 // Constructs a ProxyConfigService that watches the Mac OS system settings.
26 // This instance is expected to be operated and deleted on the same thread 26 // This instance is expected to be operated and deleted on the same thread
27 // (however it may be constructed from a different thread). 27 // (however it may be constructed from a different thread).
28 explicit ProxyConfigServiceMac( 28 explicit ProxyConfigServiceMac(
29 const scoped_refptr<base::SingleThreadTaskRunner>& io_thread_task_runner); 29 const scoped_refptr<base::SingleThreadTaskRunner>& io_thread_task_runner);
30 virtual ~ProxyConfigServiceMac(); 30 ~ProxyConfigServiceMac() override;
31 31
32 public: 32 public:
33 // ProxyConfigService implementation: 33 // ProxyConfigService implementation:
34 virtual void AddObserver(Observer* observer) override; 34 void AddObserver(Observer* observer) override;
35 virtual void RemoveObserver(Observer* observer) override; 35 void RemoveObserver(Observer* observer) override;
36 virtual ConfigAvailability GetLatestProxyConfig(ProxyConfig* config) override; 36 ConfigAvailability GetLatestProxyConfig(ProxyConfig* config) override;
37 37
38 private: 38 private:
39 class Helper; 39 class Helper;
40 40
41 // Forwarder just exists to keep the NetworkConfigWatcherMac API out of 41 // Forwarder just exists to keep the NetworkConfigWatcherMac API out of
42 // ProxyConfigServiceMac's public API. 42 // ProxyConfigServiceMac's public API.
43 class Forwarder : public NetworkConfigWatcherMac::Delegate { 43 class Forwarder : public NetworkConfigWatcherMac::Delegate {
44 public: 44 public:
45 explicit Forwarder(ProxyConfigServiceMac* proxy_config_service) 45 explicit Forwarder(ProxyConfigServiceMac* proxy_config_service)
46 : proxy_config_service_(proxy_config_service) {} 46 : proxy_config_service_(proxy_config_service) {}
47 47
48 // NetworkConfigWatcherMac::Delegate implementation: 48 // NetworkConfigWatcherMac::Delegate implementation:
49 virtual void StartReachabilityNotifications() override {} 49 void StartReachabilityNotifications() override {}
50 virtual void SetDynamicStoreNotificationKeys( 50 void SetDynamicStoreNotificationKeys(SCDynamicStoreRef store) override;
51 SCDynamicStoreRef store) override; 51 void OnNetworkConfigChange(CFArrayRef changed_keys) override;
52 virtual void OnNetworkConfigChange(CFArrayRef changed_keys) override;
53 52
54 private: 53 private:
55 ProxyConfigServiceMac* const proxy_config_service_; 54 ProxyConfigServiceMac* const proxy_config_service_;
56 DISALLOW_COPY_AND_ASSIGN(Forwarder); 55 DISALLOW_COPY_AND_ASSIGN(Forwarder);
57 }; 56 };
58 57
59 // Methods directly called by the NetworkConfigWatcherMac::Delegate: 58 // Methods directly called by the NetworkConfigWatcherMac::Delegate:
60 void SetDynamicStoreNotificationKeys(SCDynamicStoreRef store); 59 void SetDynamicStoreNotificationKeys(SCDynamicStoreRef store);
61 void OnNetworkConfigChange(CFArrayRef changed_keys); 60 void OnNetworkConfigChange(CFArrayRef changed_keys);
62 61
(...skipping 13 matching lines...) Expand all
76 75
77 // The thread that we expect to be operated on. 76 // The thread that we expect to be operated on.
78 const scoped_refptr<base::SingleThreadTaskRunner> io_thread_task_runner_; 77 const scoped_refptr<base::SingleThreadTaskRunner> io_thread_task_runner_;
79 78
80 DISALLOW_COPY_AND_ASSIGN(ProxyConfigServiceMac); 79 DISALLOW_COPY_AND_ASSIGN(ProxyConfigServiceMac);
81 }; 80 };
82 81
83 } // namespace net 82 } // namespace net
84 83
85 #endif // NET_PROXY_PROXY_CONFIG_SERVICE_MAC_H_ 84 #endif // NET_PROXY_PROXY_CONFIG_SERVICE_MAC_H_
OLDNEW
« no previous file with comments | « net/proxy/proxy_config_service_fixed.h ('k') | net/proxy/proxy_resolver_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698