Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Side by Side Diff: net/dns/dns_socket_pool.cc

Issue 667923003: Standardize usage of virtual/override/final in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/dns/dns_session_unittest.cc ('k') | net/dns/dns_test_util.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/dns/dns_socket_pool.h" 5 #include "net/dns/dns_socket_pool.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/rand_util.h" 8 #include "base/rand_util.h"
9 #include "base/stl_util.h" 9 #include "base/stl_util.h"
10 #include "net/base/address_list.h" 10 #include "net/base/address_list.h"
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 88
89 return socket.Pass(); 89 return socket.Pass();
90 } 90 }
91 91
92 class NullDnsSocketPool : public DnsSocketPool { 92 class NullDnsSocketPool : public DnsSocketPool {
93 public: 93 public:
94 NullDnsSocketPool(ClientSocketFactory* factory) 94 NullDnsSocketPool(ClientSocketFactory* factory)
95 : DnsSocketPool(factory) { 95 : DnsSocketPool(factory) {
96 } 96 }
97 97
98 virtual void Initialize( 98 void Initialize(const std::vector<IPEndPoint>* nameservers,
99 const std::vector<IPEndPoint>* nameservers, 99 NetLog* net_log) override {
100 NetLog* net_log) override {
101 InitializeInternal(nameservers, net_log); 100 InitializeInternal(nameservers, net_log);
102 } 101 }
103 102
104 virtual scoped_ptr<DatagramClientSocket> AllocateSocket( 103 scoped_ptr<DatagramClientSocket> AllocateSocket(
105 unsigned server_index) override { 104 unsigned server_index) override {
106 return CreateConnectedSocket(server_index); 105 return CreateConnectedSocket(server_index);
107 } 106 }
108 107
109 virtual void FreeSocket( 108 void FreeSocket(unsigned server_index,
110 unsigned server_index, 109 scoped_ptr<DatagramClientSocket> socket) override {}
111 scoped_ptr<DatagramClientSocket> socket) override {
112 }
113 110
114 private: 111 private:
115 DISALLOW_COPY_AND_ASSIGN(NullDnsSocketPool); 112 DISALLOW_COPY_AND_ASSIGN(NullDnsSocketPool);
116 }; 113 };
117 114
118 // static 115 // static
119 scoped_ptr<DnsSocketPool> DnsSocketPool::CreateNull( 116 scoped_ptr<DnsSocketPool> DnsSocketPool::CreateNull(
120 ClientSocketFactory* factory) { 117 ClientSocketFactory* factory) {
121 return scoped_ptr<DnsSocketPool>(new NullDnsSocketPool(factory)); 118 return scoped_ptr<DnsSocketPool>(new NullDnsSocketPool(factory));
122 } 119 }
123 120
124 class DefaultDnsSocketPool : public DnsSocketPool { 121 class DefaultDnsSocketPool : public DnsSocketPool {
125 public: 122 public:
126 DefaultDnsSocketPool(ClientSocketFactory* factory) 123 DefaultDnsSocketPool(ClientSocketFactory* factory)
127 : DnsSocketPool(factory) { 124 : DnsSocketPool(factory) {
128 }; 125 };
129 126
130 virtual ~DefaultDnsSocketPool(); 127 ~DefaultDnsSocketPool() override;
131 128
132 virtual void Initialize( 129 void Initialize(const std::vector<IPEndPoint>* nameservers,
133 const std::vector<IPEndPoint>* nameservers, 130 NetLog* net_log) override;
134 NetLog* net_log) override;
135 131
136 virtual scoped_ptr<DatagramClientSocket> AllocateSocket( 132 scoped_ptr<DatagramClientSocket> AllocateSocket(
137 unsigned server_index) override; 133 unsigned server_index) override;
138 134
139 virtual void FreeSocket( 135 void FreeSocket(unsigned server_index,
140 unsigned server_index, 136 scoped_ptr<DatagramClientSocket> socket) override;
141 scoped_ptr<DatagramClientSocket> socket) override;
142 137
143 private: 138 private:
144 void FillPool(unsigned server_index, unsigned size); 139 void FillPool(unsigned server_index, unsigned size);
145 140
146 typedef std::vector<DatagramClientSocket*> SocketVector; 141 typedef std::vector<DatagramClientSocket*> SocketVector;
147 142
148 std::vector<SocketVector> pools_; 143 std::vector<SocketVector> pools_;
149 144
150 DISALLOW_COPY_AND_ASSIGN(DefaultDnsSocketPool); 145 DISALLOW_COPY_AND_ASSIGN(DefaultDnsSocketPool);
151 }; 146 };
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 for (unsigned pool_index = pool.size(); pool_index < size; ++pool_index) { 208 for (unsigned pool_index = pool.size(); pool_index < size; ++pool_index) {
214 DatagramClientSocket* socket = 209 DatagramClientSocket* socket =
215 CreateConnectedSocket(server_index).release(); 210 CreateConnectedSocket(server_index).release();
216 if (!socket) 211 if (!socket)
217 break; 212 break;
218 pool.push_back(socket); 213 pool.push_back(socket);
219 } 214 }
220 } 215 }
221 216
222 } // namespace net 217 } // namespace net
OLDNEW
« no previous file with comments | « net/dns/dns_session_unittest.cc ('k') | net/dns/dns_test_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698