Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 667913003: Reparented overflow controls host layer must account for scrolling. (Closed)

Created:
6 years, 1 month ago by Ian Vollick
Modified:
6 years, 1 month ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Project:
blink
Visibility:
Public.

Description

Reparented overflow controls host layer must account for scrolling. The math to position the host layer does not account for scrolling, and this causes incorrect behavior with nested scrollers. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185149

Patch Set 1 #

Patch Set 2 : Adding layout test #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/compositing/scrollbars/nested-overlay-scrollbars.html View 1 1 chunk +62 lines, -0 lines 2 comments Download
A LayoutTests/compositing/scrollbars/nested-overlay-scrollbars-expected.txt View 1 1 chunk +107 lines, -0 lines 0 comments Download
A + LayoutTests/platform/linux/compositing/scrollbars/nested-overlay-scrollbars-expected.png View 1 Binary file 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Ian Vollick
6 years, 1 month ago (2014-11-10 14:27:25 UTC) #2
Ian Vollick
On 2014/11/10 14:27:25, vollick wrote: Ping
6 years, 1 month ago (2014-11-11 17:20:56 UTC) #3
chrishtr
No bug? https://codereview.chromium.org/667913003/diff/20001/LayoutTests/compositing/scrollbars/nested-overlay-scrollbars.html File LayoutTests/compositing/scrollbars/nested-overlay-scrollbars.html (right): https://codereview.chromium.org/667913003/diff/20001/LayoutTests/compositing/scrollbars/nested-overlay-scrollbars.html#newcode51 LayoutTests/compositing/scrollbars/nested-overlay-scrollbars.html:51: document.getElementById("outer").scrollTop = 600; Scroll to 700 so ...
6 years, 1 month ago (2014-11-11 17:25:13 UTC) #4
Ian Vollick
Nope, no bug. I happened to run across this issue when putting a demo together ...
6 years, 1 month ago (2014-11-11 20:28:31 UTC) #5
chrishtr
lgtm
6 years, 1 month ago (2014-11-11 21:11:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667913003/20001
6 years, 1 month ago (2014-11-11 22:46:52 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 23:03:26 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 185149

Powered by Google App Engine
This is Rietveld 408576698