Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 667903004: Add an --msan flag to run-tests.py. (Closed)

Created:
6 years, 2 months ago by earthdok
Modified:
6 years, 1 month ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

Add an --msan flag to run-tests.py. Currently a no-op and added only for consistency with ASan/TSan. BUG=chromium:425187 R=machenbach@chromium.org LOG=N Committed: https://code.google.com/p/v8/source/detail?r=24805

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/run-deopt-fuzzer.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/run-tests.py View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
earthdok
please review/land
6 years, 2 months ago (2014-10-21 13:57:41 UTC) #1
Michael Achenbach
https://codereview.chromium.org/667903004/diff/1/tools/run-tests.py File tools/run-tests.py (right): https://codereview.chromium.org/667903004/diff/1/tools/run-tests.py#newcode514 tools/run-tests.py:514: "tsan": options.tsan, You'll need an entry here. And a ...
6 years, 2 months ago (2014-10-21 14:03:24 UTC) #2
earthdok
On 2014/10/21 14:03:24, Michael Achenbach wrote: > https://codereview.chromium.org/667903004/diff/1/tools/run-tests.py > File tools/run-tests.py (right): > > https://codereview.chromium.org/667903004/diff/1/tools/run-tests.py#newcode514 ...
6 years, 2 months ago (2014-10-21 14:14:20 UTC) #3
Michael Achenbach
lgtm
6 years, 2 months ago (2014-10-21 14:16:51 UTC) #4
earthdok
On 2014/10/21 14:16:51, Michael Achenbach wrote: > lgtm Please land.
6 years, 2 months ago (2014-10-21 14:40:06 UTC) #5
Michael Achenbach
6 years, 1 month ago (2014-10-22 12:54:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24805 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698