tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 5a05ca5288e342fa5e1bf5e298246419e03ad9dd..69203bf530541f7037fb0e6cc2917a2e20df67c8 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -10003,6 +10003,37 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="Hotword.HotwordMediaStreamError"
+    enum="HotwordMediaStreamError">
+  <owner>amistry@chromium.org</owner>
+  <owner>rlp@chromium.org</owner>
+  <owner>somast@chromium.org</owner>
+  <summary>
+    Errors when attempting to open a MediaStream for the microphone.

[Mark P, 2014/10/22 21:20:17]

Do you have a histogram or something that allows normalizing this one to tell
how often errors are a whole happen?

[Mark P, 2014/10/22 21:20:17]

Is it possible the same stream causes multiple errors (e.g., invalid origin
certificate, permission dismissed)?

[Anand Mistry (off Chromium), 2014/10/22 22:14:14]

No. This error occurs on the attempt to open the stream, which only returns one
error. If it fails, we don't have a valid stream to produce more errors.

[Anand Mistry (off Chromium), 2014/10/22 22:14:15]

Are you suggesting to have a success/fail histogram for this? I don't currently
have one, but it's trivial for me to add. Would adding a "success" enum value to
this (and other) histogram be appropriate instead?

[Mark P, 2014/10/22 22:32:16]

Either method (success/fail histogram or adding success enum) is fine.  Or
neither.  I was mostly pointing out that many people find having the denominator
useful.  If you think you might too, record it in whichever way you want. :-)

[Mark P, 2014/10/22 22:32:17]

optional suggestion: Say explicitly something like
// Errors are detected serially, meaning that at most one error will be emitted
for an attempt to open a stream.

[Anand Mistry (off Chromium), 2014/10/23 00:20:37]

Done. I think it's useful.

[Anand Mistry (off Chromium), 2014/10/23 00:20:37]

Done, although not so wordy.

[Mark P, 2014/10/23 18:54:00]

Yeah, I tend to be wordy. :-)

+  </summary>
+</histogram>
+
+<histogram name="Hotword.HotwordNaClMessageTimeout"
+    enum="HotwordNaClMessageTimeout">
+  <owner>amistry@chromium.org</owner>
+  <owner>rlp@chromium.org</owner>
+  <owner>somast@chromium.org</owner>
+  <summary>
+    Timeout occured while waiting for a message from the NaCl hotword detector
+    plugin. This value is the message that was expected to be received from the
+    plugin.

[Mark P, 2014/10/22 21:20:17]

For my information, if the NaCl plugin failed to load (as recorded in the below
histogram), nothing will end up being recorded here, right?

[Anand Mistry (off Chromium), 2014/10/22 22:14:15]

Correct.

+  </summary>
+</histogram>
+
+<histogram name="Hotword.HotwordNaClPluginError" enum="HotwordNaClPluginError">
+  <owner>amistry@chromium.org</owner>
+  <owner>rlp@chromium.org</owner>
+  <owner>somast@chromium.org</owner>
+  <summary>
+    Errors when attempting to load the NaCl hotword detector plugin.
+  </summary>
+</histogram>
+
 <histogram name="HttpCache.AsyncValidationDuration" units="milliseconds">
   <owner>ricea@chromium.org</owner>
   <summary>
@@ -44769,6 +44800,37 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <int value="3" label="Microphone error"/>
 </enum>
 
+<enum name="HotwordMediaStreamError" type="int">
+  <int value="0" label="Unknown error"/>
+  <int value="1" label="NotSupportedError"/>
+  <int value="2" label="PermissionDeniedError"/>
+  <int value="3" label="ConstraintNotSatisfiedError"/>
+  <int value="4" label="OverconstrainedError"/>
+  <int value="5" label="NotFoundError"/>
+  <int value="6" label="AbortError"/>
+  <int value="7" label="SourceUnavailableError"/>
+  <int value="8" label="PermissionDismissedError"/>
+  <int value="9" label="InvalidStateError"/>
+  <int value="10" label="DevicesNotFoundError"/>
+  <int value="11" label="InvalidSecurityOriginError"/>
+</enum>
+
+<enum name="HotwordNaClMessageTimeout" type="int">
+  <int value="0" label="REQUEST_MODEL"/>
+  <int value="1" label="MODEL_LOADED"/>
+  <int value="2" label="READY_FOR_AUDIO"/>
+  <int value="3" label="STOPPED"/>
+  <int value="4" label="HOTWORD_DETECTED"/>
+  <int value="5" label="MS_CONFIGURED"/>
+</enum>
+
+<enum name="HotwordNaClPluginError" type="int">
+  <int value="0" label="Unknown error"/>
+  <int value="1" label="Module crash"/>
+  <int value="2" label="Module not found"/>
+  <int value="3" label="Message timeout"/>
+</enum>
+
 <enum name="HotwordPrefState" type="int">
   <int value="0" label="Preference not set"/>
   <int value="1" label="Hotwording enabled"/>