Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 667843005: Files.app: Refactoring for the onMessage function of FIleManagerBrowserTest. (Closed)

Created:
6 years, 2 months ago by hirono
Modified:
6 years, 2 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Files.app: Refactoring for the onMessage function of FileManagerBrowserTest. Previously onMessage function of FileManagerBrowserTest returns a string, but the format of the return values is not consistent among the message types. Also the onMessage function retunrs the value even if it is fatal error, but for the case, we can stop the test directly in the function. The CL removes unrequired result values, and adds test assertions for fatal errors. BUG=None TEST=None Committed: https://crrev.com/15161ce4e44d4945e6e7bdef17b2ca2d316e1578 Cr-Commit-Position: refs/heads/master@{#301076}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Rebased. #

Patch Set 5 : Fix test. #

Patch Set 6 : Let the tests fail when onMessage has fatal errors. #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -73 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 2 3 4 5 6 10 chunks +69 lines, -66 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/copy_between_windows.js View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_manager_browsertest/file_manager/file_display.js View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_manager_browsertest/test_util.js View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
hirono
PTAL the CL? Thank you!
6 years, 2 months ago (2014-10-23 06:55:22 UTC) #2
mtomasz
lgtm!
6 years, 2 months ago (2014-10-23 07:49:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667843005/40001
6 years, 2 months ago (2014-10-23 07:51:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32 on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32/builds/3940)
6 years, 2 months ago (2014-10-23 08:18:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667843005/40001
6 years, 2 months ago (2014-10-23 09:26:26 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32 on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32/builds/4044) linux_chromium_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel/builds/2157)
6 years, 2 months ago (2014-10-23 09:54:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667843005/60001
6 years, 2 months ago (2014-10-23 11:46:14 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/4325)
6 years, 2 months ago (2014-10-23 13:03:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667843005/80001
6 years, 2 months ago (2014-10-24 07:22:34 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667843005/120001
6 years, 2 months ago (2014-10-24 08:29:36 UTC) #20
commit-bot: I haz the power
Committed patchset #7 (id:120001)
6 years, 2 months ago (2014-10-24 09:23:30 UTC) #21
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 09:24:28 UTC) #22
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/15161ce4e44d4945e6e7bdef17b2ca2d316e1578
Cr-Commit-Position: refs/heads/master@{#301076}

Powered by Google App Engine
This is Rietveld 408576698