chrome/test/data/extensions/api_test/keybinding/update/mk_v1/manifest.json - Issue 667833004: Fix extension command service to check if user has modified key before overwrite on update.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/keybinding/update/mk_v1/manifest.json

Issue 667833004: Fix extension command service to check if user has modified key before overwrite on update. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code cleanup Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/extension_keybinding_apitest.cc ('K') | « chrome/test/data/extensions/api_test/keybinding/update/mk_v1/background.js ('k') | chrome/test/data/extensions/api_test/keybinding/update/mk_v2/background.js » ('j') | chrome/test/data/extensions/api_test/keybinding/update/mk_v2/manifest.json » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 {

	2 "name": "A test for making sure media keys that get reassigned don't get reins tated

	3 during update.",
	Finnur 2014/10/23 09:09:54 nit: this looks a bit weird, is there a line break nit: this looks a bit weird, is there a line break in the wrong location?
	4 "version": "1.0",

	5 "manifest_version": 2,

	6 "background": {

	7 "scripts": ["background.js"]

	8 },

	9 "permissions": ["activeTab"],

	10 "commands": {

	11 "test_mediakeys_update": {

	12 "suggested_key": {

	13 "default": "MediaPlayPause"

	14 },

	15 "description": "Test for mediakeys update overwrite",

	16 "global": true

	17 }

	18 }

	19 }

OLD	NEW