extensions/common/manifest_constants.h - Issue 667833004: Fix extension command service to check if user has modified key before overwrite on update.

Side by Side Diff: extensions/common/manifest_constants.h

Issue 667833004: Fix extension command service to check if user has modified key before overwrite on update. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/test/data/extensions/api_test/keybinding/update/mk_v2/manifest.json ('K') | « chrome/test/data/extensions/api_test/keybinding/update/mk_v2/manifest.json ('k') | extensions/common/manifest_constants.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef EXTENSIONS_COMMON_MANIFEST_CONSTANTS_H_	5 #ifndef EXTENSIONS_COMMON_MANIFEST_CONSTANTS_H_

6 #define EXTENSIONS_COMMON_MANIFEST_CONSTANTS_H_	6 #define EXTENSIONS_COMMON_MANIFEST_CONSTANTS_H_

7	7

8 namespace extensions {	8 namespace extensions {

9	9

10 // Keys used in JSON representation of extensions.	10 // Keys used in JSON representation of extensions.

(...skipping 217 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
228 extern const char kLaunchContainerPanel[];	228 extern const char kLaunchContainerPanel[];

229 extern const char kLaunchContainerTab[];	229 extern const char kLaunchContainerTab[];

230 extern const char kLaunchContainerWindow[];	230 extern const char kLaunchContainerWindow[];

231 extern const char kPageActionCommandEvent[];	231 extern const char kPageActionCommandEvent[];

232 extern const char kPageActionTypePermanent[];	232 extern const char kPageActionTypePermanent[];

233 extern const char kPageActionTypeTab[];	233 extern const char kPageActionTypeTab[];

234 extern const char kScriptBadgeCommandEvent[];	234 extern const char kScriptBadgeCommandEvent[];

235 extern const char kRunAtDocumentEnd[];	235 extern const char kRunAtDocumentEnd[];

236 extern const char kRunAtDocumentIdle[];	236 extern const char kRunAtDocumentIdle[];

237 extern const char kRunAtDocumentStart[];	237 extern const char kRunAtDocumentStart[];

	238 extern const char kMediaKeyTestCommand[];
	Finnur 2014/10/22 09:43:03 You only seem to use this in the test file, so I w You only seem to use this in the test file, so I wouldn't add it here. Just define it locally at the top of the test .cc file (in the anonymous namespace).
238	239

239 } // namespace manifest_values	240 } // namespace manifest_values

240	241

241 // Error messages returned from extension installation.	242 // Error messages returned from extension installation.

242 namespace manifest_errors {	243 namespace manifest_errors {

243	244

244 extern const char kActiveTabPermissionNotGranted[];	245 extern const char kActiveTabPermissionNotGranted[];

245 extern const char kAllURLOrActiveTabNeeded[];	246 extern const char kAllURLOrActiveTabNeeded[];

246 extern const char kAppsNotEnabled[];	247 extern const char kAppsNotEnabled[];

247 extern const char kBackgroundPermissionNeeded[];	248 extern const char kBackgroundPermissionNeeded[];

(...skipping 231 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
479 extern const char kWebRequestConflictsWithLazyBackground[];	480 extern const char kWebRequestConflictsWithLazyBackground[];

480 #if defined(OS_CHROMEOS)	481 #if defined(OS_CHROMEOS)

481 extern const char kIllegalPlugins[];	482 extern const char kIllegalPlugins[];

482 #endif	483 #endif

483	484

484 } // namespace manifest_errors	485 } // namespace manifest_errors

485	486

486 } // namespace extensions	487 } // namespace extensions

487	488

488 #endif // EXTENSIONS_COMMON_MANIFEST_CONSTANTS_H_	489 #endif // EXTENSIONS_COMMON_MANIFEST_CONSTANTS_H_

OLD	NEW