Remove SK_FONTHOST_USES_FONTMGR.

Remove SK_FONTHOST_USES_FONTMGR.

Committed: https://code.google.com/p/skia/source/detail?r=12217

[bungeman-skia, 2013-11-08 20:55:55]

https://codereview.chromium.org/66783003/diff/60003/include/core/SkTypeface.h
File include/core/SkTypeface.h (left):

https://codereview.chromium.org/66783003/diff/60003/include/core/SkTypeface.h...
include/core/SkTypeface.h:292: SkTypeface* refMatchingStyle(Style) const;
This is what I was discussing with you previously, that this should be removed
as it is the only place where the typeface should have a back pointer to whence
it came (which it may not even have). This was introduced just for FontHost,
which was the only user. This CL changes FontHost to just use the equivalent
method on the default FontMgr.

https://codereview.chromium.org/66783003/diff/60003/src/ports/SkFontHost_linu...
File src/ports/SkFontHost_linux.cpp (right):

https://codereview.chromium.org/66783003/diff/60003/src/ports/SkFontHost_linu...
src/ports/SkFontHost_linux.cpp:13: #include "SkFontMgr.h"
This file hasn't been updated in a long time, so I updated it to use the new
system in a sane way.

https://codereview.chromium.org/66783003/diff/60003/src/sfnt/SkOTTable_name.cpp
File src/sfnt/SkOTTable_name.cpp (left):

https://codereview.chromium.org/66783003/diff/60003/src/sfnt/SkOTTable_name.c...
src/sfnt/SkOTTable_name.cpp:532: SkASSERT(false);
My Ubuntu actually contains a font which claims a code of '1024', which is
probably a buggy font where they didn't use the right endianess. This assert was
here more so that I could see if such things existed. Now that I know they do,
we can remove this.

[reed1, 2013-11-08 21:24:39]

I like all the deletes.

I don't understand the SkFontStyle_Custom class. A description of it should be
in a comment (and in the CL header perhaps). Is it necessarily part of this CL,
or can it be separated?

https://codereview.chromium.org/66783003/diff/60003/src/ports/SkFontHost_linu...
File src/ports/SkFontHost_linux.cpp (right):

https://codereview.chromium.org/66783003/diff/60003/src/ports/SkFontHost_linu...
src/ports/SkFontHost_linux.cpp:127: class SkFontStyleSet_Custom : public
SkFontStyleSet {
/*
 * SkFontStyleSet_Custom
 *
 * ????
 */

[bungeman-skia, 2013-11-08 22:27:05]

All of the changes to SkFontHost_linux.cpp (including SkFontStyle_Custom and
SkFontMgr_Custom) are simply to implement the SkFontMgr for this file so that we
can remove the flag. This is currently used by the nacl build. Most of the code
here is either boilerplate or moved around bits of the old code (with a few
updates). This is best one all in one go, because I'd rather not spend the time
to support the SK_FONTHOST_USES_FONTMGR flag in this file, just to immediately
remove the supporting code in my next CL.

https://codereview.chromium.org/66783003/diff/60003/src/ports/SkFontHost_linu...
File src/ports/SkFontHost_linux.cpp (right):

https://codereview.chromium.org/66783003/diff/60003/src/ports/SkFontHost_linu...
src/ports/SkFontHost_linux.cpp:127: class SkFontStyleSet_Custom : public
SkFontStyleSet {
On 2013/11/08 21:24:39, reed1 wrote:
> /*
>  * SkFontStyleSet_Custom
>  *
>  * ????
>  */

Added a number of comments. Done.

[bungeman-skia, 2013-11-11 15:53:40]

Committed patchset #4 manually as r12217.

[bungeman-skia, 2013-11-11 20:53:20]

On 2013/11/11 15:53:40, bungeman1 wrote:
> Committed patchset #4 manually as r12217.

See also r12218, r12220, r12221, and r12224. As of this point android still
requires the old code path.