Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 667823002: PlatformEventDispatcher::DispatchEvent() should return a PostDispatchAction (Closed)

Created:
6 years, 2 months ago by Chris Masone
Modified:
6 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, extensions-reviews_chromium.org, tdanderson+views_chromium.org, ben+aura_chromium.org, tdresser+watch_chromium.org, sadrul, tfarina, dcheng, oshima+watch_chromium.org, kalyank, chromium-apps-reviews_chromium.org, ben+views_chromium.org, stevenjb+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ui_enums
Project:
chromium
Visibility:
Public.

Description

PlatformEventDispatcher::DispatchEvent() should return a PostDispatchAction Declaring DispatchEvent() as returning a uint32_t when it actually hands back a PostDispatchAction results in intermingling enum values with integer types. This causes -Wtype-limits to throw warnings on some compilers. Declaring the return type appropriately fixes this. BUG=424334 TEST=ui_unittests R=sky@chromium.org bah

Patch Set 1 #

Patch Set 2 : Fix platform_event_source_unittest.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -42 lines) Patch
M chrome/browser/extensions/global_shortcut_listener_x11.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/global_shortcut_listener_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_tree_host_x11.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/aura/window_tree_host_x11.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/base/clipboard/clipboard_aurax11.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aurax11.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aurax11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/chromeos/x11/native_display_event_dispatcher_x11.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/display/chromeos/x11/native_display_event_dispatcher_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/platform/platform_event_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/platform/platform_event_source_unittest.cc View 1 5 chunks +10 lines, -6 lines 0 comments Download
M ui/gl/gl_surface_glx.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gl/gl_surface_glx.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/ozone/platform/caca/caca_window.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/ozone/platform/caca/caca_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/dri_window.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/dri_window.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/ozone/platform/egltest/ozone_platform_egltest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/platform_window/x11/x11_window.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/platform_window/x11/x11_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_event_dispatcher_linux.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/controls/menu/menu_event_dispatcher_linux.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/test/x11_property_change_waiter.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/test/x11_property_change_waiter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/wm/core/nested_accelerator_controller_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/wm/core/nested_accelerator_dispatcher_linux.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Chris Masone
Sky, how about this approach instead? It seems like the API just has implementors return ...
6 years, 2 months ago (2014-10-20 22:24:33 UTC) #1
Chris Masone
6 years, 2 months ago (2014-10-20 22:27:22 UTC) #2
On 2014/10/20 22:24:33, Chris Masone wrote:
> Sky, how about this approach instead? It seems like the API just has
> implementors return one of the enumerated values, as opposed to allowing the
> values to be bitwise-ORed together? So this keeps the enum and just makes the
> method actually return one of the enumerated values.
> 
> This is an alternative to https://codereview.chromium.org/666673005/

Hrm. This might not work. Bah!

Powered by Google App Engine
This is Rietveld 408576698