Signal WorkerThread termination earlier

Signal WorkerThread termination earlier

This CL resolves a race in WorkerThread::cleanup.
workerThreadTerminated() notification may release a reference to the WorkerThread instance, that causes race between the termination signal.

BUG=405420
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184061

[tzik, 2014-10-21 06:53:05]

tzik@chromium.org changed reviewers:
+ aandrey@chromium.org, haraken@chromium.org

[tzik, 2014-10-21 06:57:17]

PTL

[haraken, 2014-10-21 08:11:31]

The change looks good. Will this CL fix bug
https://code.google.com/p/chromium/issues/detail?id=414380 as well?

[haraken, 2014-10-21 08:11:38]

haraken@chromium.org changed reviewers:
+ sigbjornf@opera.com

[sof, 2014-10-21 08:19:19]

On 2014/10/21 08:11:31, haraken wrote:
> The change looks good. Will this CL fix bug
> https://code.google.com/p/chromium/issues/detail?id=414380 as well?

No, no difference. Incoming CL for that.

lgtm on this one.

[haraken, 2014-10-21 08:19:50]

LGTM

[aandrey, 2014-10-21 08:19:58]

lgtm

[tzik, 2014-10-21 08:31:03]

On 2014/10/21 08:19:19, sof wrote:
> On 2014/10/21 08:11:31, haraken wrote:
> > The change looks good. Will this CL fix bug
> > https://code.google.com/p/chromium/issues/detail?id=414380 as well?
> 
> No, no difference. Incoming CL for that.
> 
> lgtm on this one.

Agree, I think this is not related to the crash.

[tzik, 2014-10-21 08:31:10]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-10-21 08:32:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/667813003/1

[commit-bot: I haz the power, 2014-10-21 09:43:50]

Committed patchset #1 (id:1) as 184061

[tzik, 2014-10-22 18:10:47]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/671913003/ by tzik@chromium.org.

The reason for reverting is: This seems to cause a crash:
http://crbug.com/426063.