Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 667753002: Treat displays with and without EDID the same way (Closed)

Created:
6 years, 2 months ago by dnicoara
Modified:
6 years, 2 months ago
Reviewers:
kenrb, Daniel Erat, spang
CC:
chromium-reviews, ozone-reviews_chromium.org, mkwst+moarreviews-ipc_chromium.org, oshima+watch_chromium.org, kalyank, piman+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Treat displays with and without EDID the same way Treating displays without EDID specially results in exiting mirror mode every time a display configuration operation happens. BUG=413278 Committed: https://crrev.com/7f1ee85f22b425e81947bc454531fc4668ef5e52 Cr-Commit-Position: refs/heads/master@{#300694}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -64 lines) Patch
M ui/display/chromeos/display_configurator.cc View 2 chunks +9 lines, -13 lines 0 comments Download
M ui/display/chromeos/display_configurator_unittest.cc View 3 chunks +1 line, -14 lines 0 comments Download
M ui/display/chromeos/test/test_display_snapshot.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/display/chromeos/test/test_display_snapshot.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M ui/display/chromeos/x11/display_snapshot_x11.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/display/chromeos/x11/display_snapshot_x11.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/display/chromeos/x11/native_display_delegate_x11.cc View 3 chunks +2 lines, -14 lines 0 comments Download
M ui/display/chromeos/x11/native_display_event_dispatcher_x11_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/display/types/display_snapshot.h View 3 chunks +0 lines, -3 lines 0 comments Download
M ui/display/types/display_snapshot.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/ozone/common/display_snapshot_proxy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/common/display_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/common/gpu/ozone_gpu_message_params.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/common/gpu/ozone_gpu_message_params.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/common/gpu/ozone_gpu_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/display_snapshot_dri.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
dnicoara
PTAL
6 years, 2 months ago (2014-10-20 17:50:21 UTC) #2
Daniel Erat
lgtm
6 years, 2 months ago (2014-10-20 20:29:43 UTC) #3
dnicoara
+spang@ for ui/ozone +kenrb@ for ui/ozone/common/gpu/*
6 years, 2 months ago (2014-10-20 20:35:53 UTC) #5
spang
lgtm
6 years, 2 months ago (2014-10-20 21:41:45 UTC) #6
dnicoara
ping for Ken for IPC review.
6 years, 2 months ago (2014-10-22 15:10:35 UTC) #7
kenrb
ipc lgtm
6 years, 2 months ago (2014-10-22 15:25:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667753002/1
6 years, 2 months ago (2014-10-22 15:28:25 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 17:35:04 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 17:35:45 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7f1ee85f22b425e81947bc454531fc4668ef5e52
Cr-Commit-Position: refs/heads/master@{#300694}

Powered by Google App Engine
This is Rietveld 408576698