Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Unified Diff: Source/devtools/front_end/sdk/ResourceTreeModel.js

Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/sdk/Resource.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sdk/ResourceTreeModel.js
diff --git a/Source/devtools/front_end/sdk/ResourceTreeModel.js b/Source/devtools/front_end/sdk/ResourceTreeModel.js
index 8dc58b8ca4737fadbe9ac3eb9b11ca9a4b27ab63..14602cfbaac03b9bd7ba1406f2039daf6a5ef38b 100644
--- a/Source/devtools/front_end/sdk/ResourceTreeModel.js
+++ b/Source/devtools/front_end/sdk/ResourceTreeModel.js
@@ -292,7 +292,7 @@ WebInspector.ResourceTreeModel.prototype = {
return;
var request = /** @type {!WebInspector.NetworkRequest} */ (event.data);
- if (request.failed || request.type === WebInspector.resourceTypes.XHR)
+ if (request.failed || request.resourceType() === WebInspector.resourceTypes.XHR)
return;
var frame = this._frames[request.frameId];
@@ -664,7 +664,7 @@ WebInspector.ResourceTreeFrame.prototype = {
// Already in the tree, we just got an extra update.
return resource;
}
- resource = new WebInspector.Resource(this.target(), request, request.url, request.documentURL, request.frameId, request.loaderId, request.type, request.mimeType);
+ resource = new WebInspector.Resource(this.target(), request, request.url, request.documentURL, request.frameId, request.loaderId, request.resourceType(), request.mimeType);
this._resourcesMap[resource.url] = resource;
this._model.dispatchEventToListeners(WebInspector.ResourceTreeModel.EventTypes.ResourceAdded, resource);
return resource;
« no previous file with comments | « Source/devtools/front_end/sdk/Resource.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698