Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: Source/devtools/front_end/network/RequestView.js

Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 WebInspector.RequestView.prototype = { 44 WebInspector.RequestView.prototype = {
45 __proto__: WebInspector.VBox.prototype 45 __proto__: WebInspector.VBox.prototype
46 } 46 }
47 47
48 /** 48 /**
49 * @param {!WebInspector.NetworkRequest} request 49 * @param {!WebInspector.NetworkRequest} request
50 * @return {boolean} 50 * @return {boolean}
51 */ 51 */
52 WebInspector.RequestView.hasTextContent = function(request) 52 WebInspector.RequestView.hasTextContent = function(request)
53 { 53 {
54 if (request.type.isTextType()) 54 if (request.resourceType().isTextType())
55 return true; 55 return true;
56 if (request.type === WebInspector.resourceTypes.Other || request.hasErrorSta tusCode()) 56 if (request.resourceType() === WebInspector.resourceTypes.Other || request.h asErrorStatusCode())
57 return !!request.content && !request.contentEncoded; 57 return !!request.content && !request.contentEncoded;
58 return false; 58 return false;
59 } 59 }
60 60
61 /** 61 /**
62 * @param {!WebInspector.NetworkRequest} request 62 * @param {!WebInspector.NetworkRequest} request
63 * @return {!WebInspector.View} 63 * @return {!WebInspector.View}
64 */ 64 */
65 WebInspector.RequestView.nonSourceViewForRequest = function(request) 65 WebInspector.RequestView.nonSourceViewForRequest = function(request)
66 { 66 {
67 switch (request.type) { 67 switch (request.resourceType()) {
68 case WebInspector.resourceTypes.Image: 68 case WebInspector.resourceTypes.Image:
69 return new WebInspector.ImageView(request.url, request.mimeType, request ); 69 return new WebInspector.ImageView(request.url, request.mimeType, request );
70 case WebInspector.resourceTypes.Font: 70 case WebInspector.resourceTypes.Font:
71 return new WebInspector.FontView(request.url); 71 return new WebInspector.FontView(request.url);
72 default: 72 default:
73 return new WebInspector.RequestView(request); 73 return new WebInspector.RequestView(request);
74 } 74 }
75 } 75 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/network/RequestResponseView.js ('k') | Source/devtools/front_end/resources/ResourcesPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698