Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Side by Side Diff: Source/devtools/front_end/network/RequestPreviewView.js

Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 if (jsonView) 115 if (jsonView)
116 return jsonView; 116 return jsonView;
117 } 117 }
118 118
119 if (this.request.hasErrorStatusCode()) { 119 if (this.request.hasErrorStatusCode()) {
120 var htmlErrorPreview = this._htmlErrorPreview(); 120 var htmlErrorPreview = this._htmlErrorPreview();
121 if (htmlErrorPreview) 121 if (htmlErrorPreview)
122 return htmlErrorPreview; 122 return htmlErrorPreview;
123 } 123 }
124 124
125 if (this.request.type === WebInspector.resourceTypes.XHR) { 125 if (this.request.resourceType() === WebInspector.resourceTypes.XHR) {
126 var jsonView = this._jsonView(); 126 var jsonView = this._jsonView();
127 if (jsonView) 127 if (jsonView)
128 return jsonView; 128 return jsonView;
129 var htmlErrorPreview = this._htmlErrorPreview(); 129 var htmlErrorPreview = this._htmlErrorPreview();
130 if (htmlErrorPreview) 130 if (htmlErrorPreview)
131 return htmlErrorPreview; 131 return htmlErrorPreview;
132 } 132 }
133 133
134 if (this._responseView.sourceView) 134 if (this._responseView.sourceView)
135 return this._responseView.sourceView; 135 return this._responseView.sourceView;
136 136
137 if (this.request.type === WebInspector.resourceTypes.Other) 137 if (this.request.resourceType() === WebInspector.resourceTypes.Other)
138 return this._createEmptyView(); 138 return this._createEmptyView();
139 139
140 return WebInspector.RequestView.nonSourceViewForRequest(this.request); 140 return WebInspector.RequestView.nonSourceViewForRequest(this.request);
141 }, 141 },
142 142
143 __proto__: WebInspector.RequestContentView.prototype 143 __proto__: WebInspector.RequestContentView.prototype
144 } 144 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/network/NetworkPanel.js ('k') | Source/devtools/front_end/network/RequestResponseView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698