Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: Source/devtools/front_end/console/ConsoleView.js

Issue 667743002: DevTools: remove "type" getters in Resource and NetworkRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 639 matching lines...) Expand 10 before | Expand all | Expand 10 after
650 hasFilters = true; 650 hasFilters = true;
651 } 651 }
652 652
653 filterSubMenu.setEnabled(hasFilters || (consoleMessage && consoleMessage .url)); 653 filterSubMenu.setEnabled(hasFilters || (consoleMessage && consoleMessage .url));
654 unhideAll.setEnabled(hasFilters); 654 unhideAll.setEnabled(hasFilters);
655 655
656 contextMenu.appendSeparator(); 656 contextMenu.appendSeparator();
657 contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMe nuTitles() ? "Clear console" : "Clear Console"), this._requestClearMessages.bind (this)); 657 contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMe nuTitles() ? "Clear console" : "Clear Console"), this._requestClearMessages.bind (this));
658 658
659 var request = consoleMessage ? consoleMessage.request : null; 659 var request = consoleMessage ? consoleMessage.request : null;
660 if (request && request.type === WebInspector.resourceTypes.XHR) { 660 if (request && request.resourceType() === WebInspector.resourceTypes.XHR ) {
661 contextMenu.appendSeparator(); 661 contextMenu.appendSeparator();
662 contextMenu.appendItem(WebInspector.UIString("Replay XHR"), NetworkA gent.replayXHR.bind(null, request.requestId)); 662 contextMenu.appendItem(WebInspector.UIString("Replay XHR"), NetworkA gent.replayXHR.bind(null, request.requestId));
663 } 663 }
664 664
665 contextMenu.show(); 665 contextMenu.show();
666 }, 666 },
667 667
668 /** 668 /**
669 * @param {!WebInspector.ConsoleViewMessage} lastMessage 669 * @param {!WebInspector.ConsoleViewMessage} lastMessage
670 * @param {?WebInspector.ConsoleViewMessage} viewMessage 670 * @param {?WebInspector.ConsoleViewMessage} viewMessage
(...skipping 613 matching lines...) Expand 10 before | Expand all | Expand 10 after
1284 WebInspector.ConsoleView.ShowConsoleActionDelegate.prototype = { 1284 WebInspector.ConsoleView.ShowConsoleActionDelegate.prototype = {
1285 /** 1285 /**
1286 * @return {boolean} 1286 * @return {boolean}
1287 */ 1287 */
1288 handleAction: function() 1288 handleAction: function()
1289 { 1289 {
1290 WebInspector.console.show(); 1290 WebInspector.console.show();
1291 return true; 1291 return true;
1292 } 1292 }
1293 } 1293 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/bindings/NetworkUISourceCodeProvider.js ('k') | Source/devtools/front_end/elements/ElementsPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698