Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 667733004: Revert of Wait 60s instead of 30s for browser to launch. (Closed)

Created:
6 years, 1 month ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 1 month ago
Reviewers:
nednguyen, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org, nednguyen, dtu, jbauman, hendrikw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Wait 60s instead of 30s for browser to launch. (patchset #1 id:1 of https://codereview.chromium.org/691683002/) Reason for revert: Didn't help -- stuck subprocesses are still showing up. Original issue's description: > Wait 60s instead of 30s for browser to launch. > > There's a guess that the browser may be launching extremely slowly on > some bots and that when the browser main process is killed it's > leaking sub-processes that are in the middle of being spawned. > Increase the timeout to try to confirm this hypothesis. > > BUG=424024 > R=tonyg@chromium.org > > Committed: https://crrev.com/7ef2c0036f70bdcc59dd7c8f23c8b7c5a3f114d9 > Cr-Commit-Position: refs/heads/master@{#302087} TBR=tonyg@chromium.org,nednguyen@google.com NOTREECHECKS=true NOTRY=true BUG=424024 Committed: https://crrev.com/c598228e3ae5d364aeaf9889754f3f4b132815e2 Cr-Commit-Position: refs/heads/master@{#302128}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ken Russell (switch to Gerrit)
Created Revert of Wait 60s instead of 30s for browser to launch.
6 years, 1 month ago (2014-10-30 19:17:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667733004/1
6 years, 1 month ago (2014-10-30 19:19:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 19:21:08 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 19:22:26 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c598228e3ae5d364aeaf9889754f3f4b132815e2
Cr-Commit-Position: refs/heads/master@{#302128}

Powered by Google App Engine
This is Rietveld 408576698