Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 667723003: Prefix CommandLine usage with base namespace (Part 3: apps/) (Closed)

Created:
6 years, 2 months ago by elecro
Modified:
6 years, 1 month ago
Reviewers:
scheib, brettw
CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Prefix CommandLine usage with base namespace (Part 3: apps/) Prefix all CommandLine usage in the apps/ directory with the base:: namespace. R=scheib@chromium.org BUG=422426 Committed: https://crrev.com/214274b4ce335f6d9356442dac34b6b2cf80639d Cr-Commit-Position: refs/heads/master@{#301607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M apps/app_load_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M apps/launcher.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M apps/load_and_launch_browsertest.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
elecro
Please take a look.
6 years, 2 months ago (2014-10-22 12:31:19 UTC) #2
scheib
lgtm
6 years, 2 months ago (2014-10-22 13:59:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667723003/1
6 years, 2 months ago (2014-10-22 14:01:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/28283)
6 years, 2 months ago (2014-10-22 15:14:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667723003/1
6 years, 1 month ago (2014-10-28 08:06:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-28 11:59:55 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 12:01:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/214274b4ce335f6d9356442dac34b6b2cf80639d
Cr-Commit-Position: refs/heads/master@{#301607}

Powered by Google App Engine
This is Rietveld 408576698