Move migration code out of WebDatabase and into table-specific classes.

Move migration code out of WebDatabase and into table-specific classes.
- Currently this only affects AutofillTable and KeywordTable.
- Delete autofill_util as those functions can go back into an anonymous
namespace within autofill_table.cc
- Add helper functions for the migration code to reduce code duplication.
- This is the final refactor CL for WebDatabase.

R=dhollowa@chromium.org
BUG=none
TEST=anything WebDatabase/Migration/Table related.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80460

[dhollowa, 2011-04-04 16:13:20]

Thanks for splitting these out.  Nice cleanup!

http://codereview.chromium.org/6677124/diff/1/chrome/browser/webdata/autofill...
File chrome/browser/webdata/autofill_table.cc (right):

http://codereview.chromium.org/6677124/diff/1/chrome/browser/webdata/autofill...
chrome/browser/webdata/autofill_table.cc:388: }  // anonymous namespace
nit: s/anonymous namespace/namespace/

http://codereview.chromium.org/6677124/diff/1/chrome/browser/webdata/autofill...
chrome/browser/webdata/autofill_table.cc:1515: // Add the card_number_encrypted
column if credit card table was not
This comment block now describes the migration method.  Feels like it should be
pulled up above the function definition.  Same with the others.

http://codereview.chromium.org/6677124/diff/1/chrome/browser/webdata/autofill...
File chrome/browser/webdata/autofill_table.h (right):

http://codereview.chromium.org/6677124/diff/1/chrome/browser/webdata/autofill...
chrome/browser/webdata/autofill_table.h:263: bool
AddCardNumberEncryptedColumnForVersion23();
How about names like |MigrateToVersion23EncryptedCards|,
|MigrateToVersion24OversizedStrings|, ...?  It'd be nice to know immediately
that these are migration methods and hence are intertwined with the order of
others.

http://codereview.chromium.org/6677124/diff/1/chrome/browser/webdata/keyword_...
File chrome/browser/webdata/keyword_table.h (right):

http://codereview.chromium.org/6677124/diff/1/chrome/browser/webdata/keyword_...
chrome/browser/webdata/keyword_table.h:85: bool
AddAutoGenerateKeywordColumnForVersion21();
Similar renaming: |MigrateToVersion21...|, etc.

http://codereview.chromium.org/6677124/diff/1/chrome/browser/webdata/web_data...
File chrome/browser/webdata/web_database.h (right):

http://codereview.chromium.org/6677124/diff/1/chrome/browser/webdata/web_data...
chrome/browser/webdata/web_database.h:46: // Change the version number and
possibly the compatibility version of
These would be better pulled into the .cc as utility functions within the
anonymous namespace.

[Bons, 2011-04-05 11:05:13]

http://codereview.chromium.org/6677124/diff/1/chrome/browser/webdata/autofill...
File chrome/browser/webdata/autofill_table.cc (right):

http://codereview.chromium.org/6677124/diff/1/chrome/browser/webdata/autofill...
chrome/browser/webdata/autofill_table.cc:388: }  // anonymous namespace
On 2011/04/04 16:13:20, dhollowa wrote:
> nit: s/anonymous namespace/namespace/

Done.

http://codereview.chromium.org/6677124/diff/1/chrome/browser/webdata/autofill...
chrome/browser/webdata/autofill_table.cc:1515: // Add the card_number_encrypted
column if credit card table was not
On 2011/04/04 16:13:20, dhollowa wrote:
> This comment block now describes the migration method.  Feels like it should
be
> pulled up above the function definition.  Same with the others.

Done.

http://codereview.chromium.org/6677124/diff/1/chrome/browser/webdata/autofill...
File chrome/browser/webdata/autofill_table.h (right):

http://codereview.chromium.org/6677124/diff/1/chrome/browser/webdata/autofill...
chrome/browser/webdata/autofill_table.h:263: bool
AddCardNumberEncryptedColumnForVersion23();
On 2011/04/04 16:13:20, dhollowa wrote:
> How about names like |MigrateToVersion23EncryptedCards|,
> |MigrateToVersion24OversizedStrings|, ...?  It'd be nice to know immediately
> that these are migration methods and hence are intertwined with the order of
> others.

Done.

http://codereview.chromium.org/6677124/diff/1/chrome/browser/webdata/keyword_...
File chrome/browser/webdata/keyword_table.h (right):

http://codereview.chromium.org/6677124/diff/1/chrome/browser/webdata/keyword_...
chrome/browser/webdata/keyword_table.h:85: bool
AddAutoGenerateKeywordColumnForVersion21();
On 2011/04/04 16:13:20, dhollowa wrote:
> Similar renaming: |MigrateToVersion21...|, etc.

Done.

http://codereview.chromium.org/6677124/diff/1/chrome/browser/webdata/web_data...
File chrome/browser/webdata/web_database.h (right):

http://codereview.chromium.org/6677124/diff/1/chrome/browser/webdata/web_data...
chrome/browser/webdata/web_database.h:46: // Change the version number and
possibly the compatibility version of
On 2011/04/04 16:13:20, dhollowa wrote:
> These would be better pulled into the .cc as utility functions within the
> anonymous namespace.

Done.

[dhollowa, 2011-04-05 15:40:56]

LGTM.  Thanks!