Fix data race with interface caching

Fix data race with interface caching

R=bmeurer@chromium.org
BUG=421634
LOG=N

Committed: https://code.google.com/p/v8/source/detail?r=24774

[Benedikt Meurer, 2014-10-21 04:09:05]

https://codereview.chromium.org/667703002/diff/1/src/interface.h
File src/interface.h (right):

https://codereview.chromium.org/667703002/diff/1/src/interface.h#newcode9
src/interface.h:9: #include "src/base/lazy-instance.h"
No need for this include, see comment below.

https://codereview.chromium.org/667703002/diff/1/src/interface.h#newcode202
src/interface.h:202: static base::LazyInstance<Interface*, ValueCreate>::type
value_interface_;
Move the statics to the .cc file and hide them in namespace { }, i.e.

namespace {

base::LayzInstance<Interface*, Interface::ValueCreate>::type kValueInterface =
LAZY_INSTANCE_INITIALIZER;


base::LayzInstance<Interface*, Interface::ValueCreate>::type kConstInterface =
LAZY_INSTANCE_INITIALIZER;

}

[rossberg, 2014-10-21 10:42:52]

https://codereview.chromium.org/667703002/diff/1/src/interface.h
File src/interface.h (right):

https://codereview.chromium.org/667703002/diff/1/src/interface.h#newcode202
src/interface.h:202: static base::LazyInstance<Interface*, ValueCreate>::type
value_interface_;
On 2014/10/21 04:09:05, Benedikt Meurer wrote:
> Move the statics to the .cc file and hide them in namespace { }, i.e.
> 
> namespace {
> 
> base::LayzInstance<Interface*, Interface::ValueCreate>::type kValueInterface =
> LAZY_INSTANCE_INITIALIZER;
> 
> 
> base::LayzInstance<Interface*, Interface::ValueCreate>::type kConstInterface =
> LAZY_INSTANCE_INITIALIZER;
> 
> }

Done. Also changed them to do in-place construction.

[Benedikt Meurer, 2014-10-21 12:33:35]

lgtm

[rossberg, 2014-10-21 12:57:29]

Committed patchset #2 manually as 24774 (presubmit successful).