Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Issue 667693002: Convert fast/multicol/client-rects.html to reftest. (Closed)

Created:
6 years, 2 months ago by andersr
Modified:
6 years, 2 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Convert fast/multicol/client-rects.html to reftest. * Use standards mode. * Use inline-block to make all the content fit in content_shell. * Use 'margin: 0' for input=range to simplify the reference file. * Use a solid color rather than opacity (to deal with the rogue extra "outline" drawn for alt-imgs). R=mstensho@opera.com BUG=386567 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184128

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove use of linear-gradient. Remove compare-with-old-test. #

Total comments: 2

Patch Set 3 : Drop -webkit from box-sizing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -682 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/multicol/client-rects.html View 4 chunks +7 lines, -3 lines 0 comments Download
A LayoutTests/fast/multicol/client-rects-expected.html View 1 2 1 chunk +86 lines, -0 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/client-rects.html View 1 1 chunk +0 lines, -133 lines 0 comments Download
D LayoutTests/fast/multicol/newmulticol/compare-with-old-impl/client-rects-expected.html View 1 1 chunk +0 lines, -129 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/client-rects-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/client-rects-expected.txt View 1 chunk +0 lines, -104 lines 0 comments Download
D LayoutTests/platform/mac-lion/fast/multicol/client-rects-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/multicol/client-rects-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/client-rects-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/client-rects-expected.txt View 1 chunk +0 lines, -104 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/client-rects-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/client-rects-expected.txt View 1 chunk +0 lines, -104 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/client-rects-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/client-rects-expected.txt View 1 chunk +0 lines, -104 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
andersr
6 years, 2 months ago (2014-10-20 13:08:46 UTC) #1
mstensho (USE GERRIT)
Could you get rid of newmulticol/compare-with-old-impl/client-rects while you're at it? https://codereview.chromium.org/667693002/diff/1/LayoutTests/fast/multicol/client-rects-expected.html File LayoutTests/fast/multicol/client-rects-expected.html (right): https://codereview.chromium.org/667693002/diff/1/LayoutTests/fast/multicol/client-rects-expected.html#newcode40 ...
6 years, 2 months ago (2014-10-20 20:01:46 UTC) #2
andersr
> Could you get rid of newmulticol/compare-with-old-impl/client-rects while you're at it? Done. https://codereview.chromium.org/667693002/diff/1/LayoutTests/fast/multicol/client-rects-expected.html File LayoutTests/fast/multicol/client-rects-expected.html ...
6 years, 2 months ago (2014-10-21 06:45:50 UTC) #3
mstensho (USE GERRIT)
lgtm https://codereview.chromium.org/667693002/diff/20001/LayoutTests/fast/multicol/client-rects-expected.html File LayoutTests/fast/multicol/client-rects-expected.html (right): https://codereview.chromium.org/667693002/diff/20001/LayoutTests/fast/multicol/client-rects-expected.html#newcode31 LayoutTests/fast/multicol/client-rects-expected.html:31: -webkit-box-sizing: border-box; Just box-sizing would work too.
6 years, 2 months ago (2014-10-21 07:32:19 UTC) #4
andersr
https://codereview.chromium.org/667693002/diff/20001/LayoutTests/fast/multicol/client-rects-expected.html File LayoutTests/fast/multicol/client-rects-expected.html (right): https://codereview.chromium.org/667693002/diff/20001/LayoutTests/fast/multicol/client-rects-expected.html#newcode31 LayoutTests/fast/multicol/client-rects-expected.html:31: -webkit-box-sizing: border-box; On 2014/10/21 07:32:19, mstensho wrote: > Just ...
6 years, 2 months ago (2014-10-21 21:38:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667693002/40001
6 years, 2 months ago (2014-10-21 21:39:29 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 23:48:57 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 184128

Powered by Google App Engine
This is Rietveld 408576698