Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 667623002: DevTools: make extension server a part of core, panels' code should depend on it. (Closed)

Created:
6 years, 2 months ago by pfeldman
Modified:
6 years, 2 months ago
Reviewers:
caseq, apavlov
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: make extension server a part of core, panels' code should depend on it. drive-by removal of random selection-related undocumented extensions api capabilities. BUG=424951 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183969

Patch Set 1 #

Patch Set 2 : for review #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -902 lines) Patch
M LayoutTests/http/tests/inspector/extensions-test.js View 1 3 chunks +3 lines, -4 lines 0 comments Download
M LayoutTests/inspector/extensions/extensions-audits.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/inspector/extensions/extensions-audits-tests.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/inspector/extensions/extensions-events.html View 1 2 chunks +1 line, -14 lines 0 comments Download
M LayoutTests/inspector/extensions/extensions-events-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
M LayoutTests/inspector/extensions/extensions-sidebar.html View 1 1 chunk +7 lines, -2 lines 0 comments Download
M LayoutTests/inspector/initial-modules-load-expected.txt View 1 5 chunks +5 lines, -0 lines 0 comments Download
M LayoutTests/inspector/open-with-rendering-option-enabled-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/devtools.gypi View 4 chunks +2 lines, -2 lines 0 comments Download
A + Source/devtools/front_end/audits/AuditExtensionCategory.js View 1 8 chunks +31 lines, -18 lines 0 comments Download
M Source/devtools/front_end/audits/AuditsPanel.js View 2 chunks +16 lines, -0 lines 0 comments Download
M Source/devtools/front_end/audits/module.json View 2 chunks +4 lines, -2 lines 0 comments Download
D Source/devtools/front_end/components/ExtensionServerProxy.js View 1 chunk +0 lines, -77 lines 0 comments Download
M Source/devtools/front_end/components/module.json View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/devtools.json View 2 chunks +1 line, -1 line 0 comments Download
M Source/devtools/front_end/elements/ElementsPanel.js View 4 chunks +19 lines, -9 lines 0 comments Download
M Source/devtools/front_end/elements/module.json View 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/extensions/ExtensionAuditCategory.js View 1 chunk +17 lines, -170 lines 0 comments Download
M Source/devtools/front_end/extensions/ExtensionPanel.js View 1 chunk +19 lines, -1 line 0 comments Download
M Source/devtools/front_end/extensions/ExtensionServer.js View 1 14 chunks +56 lines, -45 lines 1 comment Download
M Source/devtools/front_end/extensions/module.json View 1 chunk +2 lines, -12 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 2 chunks +2 lines, -2 lines 1 comment Download
M Source/devtools/front_end/main/module.json View 1 chunk +1 line, -0 lines 0 comments Download
D Source/devtools/front_end/network/HAREntry.js View 1 chunk +0 lines, -439 lines 0 comments Download
M Source/devtools/front_end/network/NetworkPanel.js View 1 chunk +82 lines, -0 lines 0 comments Download
M Source/devtools/front_end/network/module.json View 1 chunk +0 lines, -1 line 0 comments Download
A + Source/devtools/front_end/sdk/HAREntry.js View 1 chunk +0 lines, -82 lines 0 comments Download
M Source/devtools/front_end/sdk/module.json View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 3 chunks +20 lines, -8 lines 0 comments Download
M Source/devtools/front_end/sources/module.json View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
pfeldman
wip
6 years, 2 months ago (2014-10-19 20:12:59 UTC) #2
pfeldman
6 years, 2 months ago (2014-10-20 09:08:21 UTC) #4
caseq
https://codereview.chromium.org/667623002/diff/20001/Source/devtools/front_end/extensions/ExtensionServer.js File Source/devtools/front_end/extensions/ExtensionServer.js (left): https://codereview.chromium.org/667623002/diff/20001/Source/devtools/front_end/extensions/ExtensionServer.js#oldcode745 Source/devtools/front_end/extensions/ExtensionServer.js:745: _notifySourceFrameSelectionChanged: function(event) Please state the fact that we remove ...
6 years, 2 months ago (2014-10-20 09:20:11 UTC) #5
caseq
lgtm
6 years, 2 months ago (2014-10-20 09:23:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667623002/20001
6 years, 2 months ago (2014-10-20 09:34:09 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 10:36:16 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 183969

Powered by Google App Engine
This is Rietveld 408576698