Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 667573005: Visual Studio provides stdint.h these days. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
Reviewers:
Sven Panne
CC:
v8-dev, Paweł Hajdan Jr.
Project:
v8
Visibility:
Public.

Description

Visual Studio provides stdint.h these days. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24751

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -18 lines) Patch
M include/v8stdint.h View 1 chunk +1 line, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
6 years, 2 months ago (2014-10-20 12:52:06 UTC) #1
Sven Panne
LGTM. Perhaps we can totally remove that file? If not, we might at least consider ...
6 years, 2 months ago (2014-10-20 12:56:27 UTC) #2
Benedikt Meurer
One step at a time...
6 years, 2 months ago (2014-10-21 04:55:29 UTC) #3
Benedikt Meurer
6 years, 2 months ago (2014-10-21 04:55:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24751 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698