Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(17)

Issue 6675014: Add error checking for poorly-formed crossystem args (Closed)

Created:
9 years, 11 months ago by Randall Spangler
Modified:
9 years, 10 months ago
Reviewers:
petkov, puneetster1
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Add error checking for poorly-formed crossystem args R=petkov@chromium.org BUG=chromium-os:13322 TEST=manual The following command lines should cause crossystem to fail with a warning about a poorly formed parameter: crossystem '' crossystem '=cros_debug' crossystem '?cros_debug' The following command line should warn that you can't use both = and ?: crossystem cros_debug?=0 (that is, it warns, not just compares with '=0') The following should print 'UNEQUAL' crossystem cros_debug? || echo UNEQUAL (because it's comparing cros_debug with an empty string) Review URL: http://codereview.chromium.org/6718012 Change-Id: I2e2851515f4914b16aba64065600fb92d9ad1a63 (cherry picked from commit f27583f08361522909e49155d8b14671f644ec85) Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=70c50c9

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M utility/crossystem_main.c View 2 chunks +19 lines, -5 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Randall Spangler
9 years, 11 months ago (2011-03-22 00:02:42 UTC) #1
petkov
LGTM http://codereview.chromium.org/6675014/diff/1/utility/crossystem_main.c File utility/crossystem_main.c (right): http://codereview.chromium.org/6675014/diff/1/utility/crossystem_main.c#newcode241 utility/crossystem_main.c:241: PrintHelp(progname); so this is not a warning but ...
9 years, 11 months ago (2011-03-22 00:13:36 UTC) #2
puneetster1
9 years, 11 months ago (2011-03-22 01:19:27 UTC) #3
Approved for R11 integration.

On 2011/03/22 00:13:36, petkov wrote:
> LGTM
> 
> http://codereview.chromium.org/6675014/diff/1/utility/crossystem_main.c
> File utility/crossystem_main.c (right):
> 
>
http://codereview.chromium.org/6675014/diff/1/utility/crossystem_main.c#newco...
> utility/crossystem_main.c:241: PrintHelp(progname);
> so this is not a warning but an error?

Powered by Google App Engine
This is Rietveld 408576698