Issue 667493002: Move init() to Init() so that flag.Parse() can be called first.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 667493002: Move init() to Init() so that flag.Parse() can be called first. (Closed)

Created:
6 years, 2 months ago by jcgregorio

Modified:
6 years, 2 months ago

Reviewers:
humper

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Move init() to Init() so that flag.Parse() can be called first. Otherwise the --log_dir flag doesn't affect where glog output goes to. TBR=humper BUG=skia: Committed: https://skia.googlesource.com/skia/+/33e6466a4faa3a58202bf056b50fdcd9dc34cc22

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	experimental/webtry/webtry.go	View		2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667493002/1

6 years, 2 months ago (2014-10-20 17:38:31 UTC) #4

commit-bot: I haz the power

6 years, 2 months ago (2014-10-20 17:44:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 33e6466a4faa3a58202bf056b50fdcd9dc34cc22