Issue 667483004: Ifdef extensions usage in RendererContextMenu.

Issue 667483004: Ifdef extensions usage in RendererContextMenu. (Closed)

Created:
6 years, 2 months ago by Lei Zhang

Modified:
6 years, 2 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Ifdef extensions usage in RendererContextMenu. BUG=424746 Committed: https://crrev.com/c33e17fc7db55732e23bb2614049b96cc70f1fc2 Cr-Commit-Position: refs/heads/master@{#300631}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -3 lines)			Patch
M	chrome/browser/renderer_context_menu/render_view_context_menu.h	View	1 2	5 chunks	+12 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_context_menu/render_view_context_menu.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_context_menu/render_view_context_menu_test_util.h	View	1 2	2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 9 (2 generated)

Lei Zhang

The unit test relies on extensions::MenuItem, so I'm excluding the tests as well.

6 years, 2 months ago (2014-10-22 01:12:18 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667483004/40001

6 years, 2 months ago (2014-10-22 03:09:54 UTC) #7

commit-bot: I haz the power

6 years, 2 months ago (2014-10-22 04:18:54 UTC) #9

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/c33e17fc7db55732e23bb2614049b96cc70f1fc2
Cr-Commit-Position: refs/heads/master@{#300631}