Issue 667483002: Account for NULL headers in streams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 667483002: Account for NULL headers in streams. (Closed)

Created:
6 years, 2 months ago by davidben

Modified:
6 years, 2 months ago

Reviewers:
Zachary Kuznia

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Account for NULL headers in streams. Again. It got lost somewhere when rebasing or splitting out https://codereview.chromium.org/625993002. This time add a regression test. BUG=416433 Committed: https://crrev.com/f911b2daffe9a87826d7ef476b3274d5837247f8 Cr-Commit-Position: refs/heads/master@{#300173}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -3 lines)			Patch
M	chrome/browser/extensions/api/streams_private/streams_private_apitest.cc	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/streams_private/handle_mime_type/background.js	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/loader/resource_dispatcher_host_impl.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667483002/20001

6 years, 2 months ago (2014-10-17 21:23:34 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-17 22:09:51 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/f911b2daffe9a87826d7ef476b3274d5837247f8
Cr-Commit-Position: refs/heads/master@{#300173}