Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 667473003: QUIC - Android - small experiment to flush http_server_properties (Closed)

Created:
6 years, 2 months ago by ramant (doing other things)
Modified:
6 years, 2 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

QUIC - Android - small experiment to flush http_server_properties changes to disk every 500ms instead of 5secs. We are hoping if QUIC is used as an alternate protocol, we will persist that information to disk quicker. Hopefully, this would improve the QUIC winning the alternate protocol race. R=rch@chromium.org Committed: https://crrev.com/708a3ef67431831c2a29aa35202fa446011020b4 Cr-Commit-Position: refs/heads/master@{#300318}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M net/http/http_server_properties_manager.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
ramant (doing other things)
6 years, 2 months ago (2014-10-17 21:48:30 UTC) #1
Ryan Hamilton
lgtm
6 years, 2 months ago (2014-10-20 17:51:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/667473003/1
6 years, 2 months ago (2014-10-20 17:57:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 19:49:56 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/708a3ef67431831c2a29aa35202fa446011020b4 Cr-Commit-Position: refs/heads/master@{#300318}
6 years, 2 months ago (2014-10-20 19:50:35 UTC) #6
ramant (doing other things)
6 years ago (2014-11-26 01:43:59 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/754563004/ by rtenneti@chromium.org.

The reason for reverting is: We have found out that this change is not needed.
When QUIC enabled experiment is used, we are persisting Alternate Protocol
information properly (we don't see high percentage of missing alternate
protocols)..

Powered by Google App Engine
This is Rietveld 408576698