Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: pkg/analysis_server/lib/src/services/generated/completion.dart

Issue 667463004: Code clean-up (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/generated/util.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/generated/completion.dart
diff --git a/pkg/analysis_server/lib/src/services/generated/completion.dart b/pkg/analysis_server/lib/src/services/generated/completion.dart
index 76bb82aa50f07bac4547a6782cc2a8a06331b6b5..fad936fe92a37b15dbbe6775191b13be8fb37c8b 100644
--- a/pkg/analysis_server/lib/src/services/generated/completion.dart
+++ b/pkg/analysis_server/lib/src/services/generated/completion.dart
@@ -31,9 +31,9 @@ import 'util.dart';
class AstNodeClassifier_CompletionEngine_typeOf extends CompletionEngine_AstNodeClassifier {
final CompletionEngine CompletionEngine_this;
- List<DartType> result;
+ DartType result = null;
- AstNodeClassifier_CompletionEngine_typeOf(this.CompletionEngine_this, this.result) : super();
+ AstNodeClassifier_CompletionEngine_typeOf(this.CompletionEngine_this);
@override
Object visitPrefixedIdentifier(PrefixedIdentifier node) => visitSimpleIdentifier(node.identifier);
@@ -45,7 +45,7 @@ class AstNodeClassifier_CompletionEngine_typeOf extends CompletionEngine_AstNode
PropertyAccessorElement accessor = elem as PropertyAccessorElement;
if (accessor.isSynthetic) {
PropertyInducingElement var2 = accessor.variable;
- result[0] = CompletionEngine_this._typeSearch(var2);
+ result = CompletionEngine_this._typeSearch(var2);
}
}
return null;
@@ -1407,11 +1407,12 @@ class CompletionEngine {
DartType _typeOf2(Expression expr) {
DartType type = expr.bestType;
if (type.isDynamic) {
- List<DartType> result = new List<DartType>(1);
- CompletionEngine_AstNodeClassifier visitor = new AstNodeClassifier_CompletionEngine_typeOf(this, result);
+ AstNodeClassifier_CompletionEngine_typeOf visitor
+ = new AstNodeClassifier_CompletionEngine_typeOf(this);
expr.accept(visitor);
- if (result[0] != null) {
- return result[0];
+ DartType result = visitor.result;
+ if (result != null) {
+ return result;
}
}
return type;
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/services/generated/util.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698